fix(app): give worktree creation a setup-length request deadline - #47694
Merged
Conversation
Hona
enabled auto-merge (squash)
September 6, 2026 23:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #47572 every request is aborted if the server has not sent response headers within 60 s.
POST /api/worktreecannot meet that: the server runsgit worktree addand then the project'scommands.startscript (fetches,bun install) before it answers. On this repo that is 90–120 s on Windows.POST /api/worktreenow gets its ownsetupRequestHeadersTimeoutMs(10 min). Still bounded, so the dead-socket protection from fix(app): time out requests the server never answers #47572 remains.GET /api/worktree,/api/worktree/refresh,DELETE, and/api/vcskeep the 60 s deadline.Follow-up worth doing separately: have the server return after
git worktree addand runcommands.startin a forked fiber with progress onworktree.updated, so the client never has to hold a multi-minute request.