Skip to content

fix(cli): preserve ACP reasoning boundaries and effort selections - #48493

Merged
nexxeln merged 3 commits into
v2from
acp-state-fixes
Sep 11, 2026
Merged

fix(cli): preserve ACP reasoning boundaries and effort selections#48493
nexxeln merged 3 commits into
v2from
acp-state-fixes

Conversation

@nexxeln

@nexxeln nexxeln commented Sep 11, 2026

Copy link
Copy Markdown
Member

Summary

  • Give each reasoning part a consistent ACP message ID during streaming and transcript replay.
  • Preserve effort when synchronizing the same model, while honoring explicit variant changes.
  • Display unset or explicit default effort as Default and allow selecting it without a named provider variant.

V2 follow-up to #48225. Related to #31961.

Testing

  • Extend existing streaming/replay and real ACP subprocess tests; no additional test cases.
  • bun test test/acp --timeout 30000 --only-failures in packages/cli: 96 passed.
  • Pre-push workspace typecheck: all 35 tasks passed.
  • Prettier and git diff --check passed.

@nexxeln
nexxeln merged commit 2df0095 into v2 Sep 11, 2026
9 of 10 checks passed
@nexxeln
nexxeln deleted the acp-state-fixes branch September 11, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant