fix(llm): retry transient HTTP 408 and 409 responses - #48680
Open
hamza-paracha wants to merge 1 commit into
Open
fix(llm): retry transient HTTP 408 and 409 responses#48680hamza-paracha wants to merge 1 commit into
hamza-paracha wants to merge 1 commit into
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Changes are fully reviewed with comprehensive test coverage and no unresolved issues.
Pull request overview
Restores retry handling for transient HTTP 408 and 409 responses in the LLM request executor.
Changes:
- Classifies HTTP 408/409 as retryable provider failures.
- Adds retry, exhaustion, and error-classification tests.
File summaries
| File | Description |
|---|---|
packages/llm/test/executor.test.ts |
Tests retry and exhaustion behavior. |
packages/llm/src/route/executor.ts |
Adds 408/409 retry classification. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #47525
This PR covers the V2 runtime. The legacy runtime is covered separately by #47524.
Type of change
What does this PR do?
Restore HTTP 408 and 409 as retryable provider failures in the LLM request executor, preserving the behavior introduced in #39391. They now use the existing retry budget, backoff, and Retry-After handling instead of failing immediately.
How did you verify your code works?
The new recovery tests and expanded error-classification test failed before the fix. All 17 executor tests now pass, including retry exhaustion, backoff, and non-retryable errors. Package
bun typecheck, Prettier, andgit diff --checkpass.Screenshots / recordings
Not a UI change.
Checklist