GH-45366: [C++][Parquet] Set is_compressed to false when data page v2 is not compressed#45367
Conversation
|
|
raulcd
left a comment
There was a problem hiding this comment.
This is a neat improvement. Thanks @mapleFU ! The last change fixed the segmentation fault on Python. I am ok with this PR but will let other experts review / approve. I am just wondering if we don't add specific tests to validate this new behavior
pitrou
left a comment
There was a problem hiding this comment.
LGTM on the principle, do you want to add a small test for it?
pitrou
left a comment
There was a problem hiding this comment.
LGTM, just two minor suggestions
|
Thanks! Would merge after all ci passed |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit c58ec9c. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Currently, if data page v2 is enabled, is_compressed is always set if Page has compression, however, this can be eliminated if:
What changes are included in this PR?
Enhancement is_compressed setting in column_writer.cc
Are these changes tested?
Yes
Are there any user-facing changes?
No