Skip to content

GH-48095: [Python][Docs] Add missing {pyarrow,compute} functions to API docs#48117

Merged
AlenkaF merged 6 commits into
apache:mainfrom
tadeja:48095_missing_pyarrow_compute_docs
Nov 20, 2025
Merged

GH-48095: [Python][Docs] Add missing {pyarrow,compute} functions to API docs#48117
AlenkaF merged 6 commits into
apache:mainfrom
tadeja:48095_missing_pyarrow_compute_docs

Conversation

@tadeja

@tadeja tadeja commented Nov 12, 2025

Copy link
Copy Markdown
Collaborator

Issue #48095 and #45322

Rationale for this change

Missing API doc entries.

What changes are included in this PR?

I've added strings for functions and options to the API doc page.

Are these changes tested?

I've built docs locally.

Are there any user-facing changes?

Docs only.

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #48095 has been automatically assigned in GitHub to PR creator.

@apache apache deleted a comment from tadeja Nov 12, 2025
@apache apache deleted a comment from github-actions Bot Nov 12, 2025
@tadeja

tadeja commented Nov 12, 2025

Copy link
Copy Markdown
Collaborator Author

I haven’t included arange as docs were not generated for it and I cannot say why yet.

@dangotbanned

Copy link
Copy Markdown

Thanks @tadeja!

I haven’t included arange as docs were not generated for it and I cannot say why yet.

I think it should have been here:

Factory Functions
-----------------
These functions create new Arrow arrays:
.. autosummary::
:toctree: ../generated/
array
nulls

Which also made me realize that some others in that module are missing too:

@AlenkaF

AlenkaF commented Nov 13, 2025

Copy link
Copy Markdown
Member

@dangotbanned that should be correct. I would also add infer_type as it seems to be missing too (though it would need a separate section or be in a subsection of Array Types).

@tadeja tadeja force-pushed the 48095_missing_pyarrow_compute_docs branch from fe36e88 to cb4cb70 Compare November 14, 2025 08:52

@AlenkaF AlenkaF left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating our API docs @tadeja!
I have added minor suggestions otherwise the changes look good. I also checked the rendered pages and found no issues.

Note, the changes in this PR would close two issues:

Maybe the second issue could be linked from the PR description also.

Comment thread docs/source/python/api/compute.rst Outdated
Comment thread docs/source/python/api/compute.rst Outdated
Comment thread docs/source/python/api/compute.rst Outdated
Comment thread docs/source/python/api/compute.rst
@github-actions github-actions Bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Nov 14, 2025
Co-authored-by: Alenka Frim <AlenkaF@users.noreply.github.com>
@tadeja

tadeja commented Nov 14, 2025

Copy link
Copy Markdown
Collaborator Author

Thanks @AlenkaF, @dangotbanned.
Just note that asarray does not seem to get picked up on the Arrays doc page. I am checking locally if adding it to pyarrow/init.py could do the trick.

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #48095 has been automatically assigned in GitHub to PR creator.

@tadeja tadeja requested review from raulcd and rok as code owners November 14, 2025 11:56
@apache apache deleted a comment from github-actions Bot Nov 14, 2025
@apache apache deleted a comment from github-actions Bot Nov 14, 2025
@github-actions

Copy link
Copy Markdown

Revision: 56043a1

Submitted crossbow builds: ursacomputing/crossbow @ actions-0ec9937bf0

Task Status
preview-docs GitHub Actions

@rok

rok commented Nov 14, 2025

Copy link
Copy Markdown
Member

@github-actions crossbow submit preview-docs

@github-actions

Copy link
Copy Markdown

Revision: bd372aa

Submitted crossbow builds: ursacomputing/crossbow @ actions-ff8cf53890

Task Status
preview-docs GitHub Actions

@AlenkaF AlenkaF left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!!

@tadeja

tadeja commented Nov 17, 2025

Copy link
Copy Markdown
Collaborator Author

@AlenkaF
Note: This PR is now adding asarray to __ init __.py, and making it publicly available where it wasn't so far.

A side note regarding added
index_in_meta_binary and is_in_meta_binary - see older items here (first #29556 then #29839)

@AlenkaF

AlenkaF commented Nov 19, 2025

Copy link
Copy Markdown
Member

Note: This PR is now adding asarray to __ init __.py, and making it publicly available where it wasn't so far.

Oh, yeah. I seem to remember we have talked about this with Joris in the past. It is a bit confusing for the user to have array and asarray available specially because asarray is a thin wrapper around array(). We might want to keep it as is for now and not add asarray to the API docs.

A side note regarding added
index_in_meta_binary and is_in_meta_binary - see older items here (first #29556 then #29839)

I think #29556 can be closed and we might want to wait for #29839 to be solved before adding index_in_meta_binary and is_in_meta_binary to the API docs?

@AlenkaF

AlenkaF commented Nov 19, 2025

Copy link
Copy Markdown
Member

Thanks @tadeja!
@raulcd would you mind having a look before I merge?

@tadeja

tadeja commented Nov 19, 2025

Copy link
Copy Markdown
Collaborator Author

@AlenkaF, thank you. So I've removed asarray, index_in_meta_binary and is_in_meta_binary from this PR for now as advised.

@AlenkaF

AlenkaF commented Nov 19, 2025

Copy link
Copy Markdown
Member

Not sure why the linter job is failing on an unrelated code.

@AlenkaF

AlenkaF commented Nov 19, 2025

Copy link
Copy Markdown
Member

There is already an open PR for the linter error here: #48173.
It is unrelated to this PR so can be merged after another pair of 👀

@raulcd

raulcd commented Nov 19, 2025

Copy link
Copy Markdown
Member

I'll try to look at this later today

@raulcd raulcd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've gone over the rendered docs and this looks great to me! Thank you very much @tadeja for the work here!

@github-actions github-actions Bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Nov 19, 2025
@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #48095 has been automatically assigned in GitHub to PR creator.

@AlenkaF AlenkaF merged commit e4b5b11 into apache:main Nov 20, 2025
7 of 8 checks passed
@AlenkaF AlenkaF removed the awaiting merge Awaiting merge label Nov 20, 2025
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit e4b5b11.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 9 possible false positives for unstable benchmarks that are known to sometimes produce them.

@tadeja tadeja deleted the 48095_missing_pyarrow_compute_docs branch February 20, 2026 15:23
Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
…s to API docs (apache#48117)

Issue apache#48095 and apache#45322
 
### Rationale for this change
Missing API doc entries. 

### What changes are included in this PR?
I've added strings for functions and options to the API doc page.

### Are these changes tested?
I've built docs locally.

### Are there any user-facing changes?
Docs only.
* GitHub Issue: apache#48095
* Also covers: apache#45322

Lead-authored-by: Tadeja Kadunc <tadeja.kadunc@gmail.com>
Co-authored-by: tadeja <tadeja@users.noreply.github.com>
Co-authored-by: Alenka Frim <AlenkaF@users.noreply.github.com>
Signed-off-by: AlenkaF <frim.alenka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants