GH-49103: [Python][Annotations] Add internal type system stubs (_types, error, _stubs_typing)#48622
Open
rok wants to merge 21 commits into
Open
GH-49103: [Python][Annotations] Add internal type system stubs (_types, error, _stubs_typing)#48622rok wants to merge 21 commits into
rok wants to merge 21 commits into
Conversation
github-actions
Bot
added
Component: Python
Component: Documentation
awaiting committer review
rok
force-pushed
the
pyarrow-stubs-pr2-core-types
branch
from
d3c5740 to
27d1c65
Compare
Member
Author
|
I've rebased this on the annotation infra check PR (#48618) to make sure we're on the right track. |
rok
force-pushed
the
pyarrow-stubs-pr2-core-types
branch
2 times, most recently
from
3f9ed3b to
0ac95b0
Compare
rok
changed the title
|
|
rok
force-pushed
the
pyarrow-stubs-pr2-core-types
branch
3 times, most recently
from
7873930 to
43e7cc6
Compare
rok
requested review from
AlenkaF,
assignUser,
jonkeane,
kou and
raulcd
as code owners
rok
force-pushed
the
pyarrow-stubs-pr2-core-types
branch
from
51a7a4e to
7bc0a98
Compare
rok
force-pushed
the
pyarrow-stubs-pr2-core-types
branch
5 times, most recently
from
0d15871 to
8f3796d
Compare
rok
force-pushed
the
pyarrow-stubs-pr2-core-types
branch
from
8f3796d to
72571d2
Compare
Co-authored-by: Dan Redding <125183946+dangotbanned@users.noreply.github.com>
Co-authored-by: Dan Redding <125183946+dangotbanned@users.noreply.github.com>
Co-authored-by: Dan Redding <125183946+dangotbanned@users.noreply.github.com>
rok
force-pushed
the
pyarrow-stubs-pr2-core-types
branch
from
99f5809 to
8982d1e
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Member
Author
|
Finally took some time to work on this again. @dangotbanned I accepted you proposals and added some other changes. Could you please take another look and maybe we can merge? |
github-actions
Bot
added
awaiting changes
github-actions
Bot
added
awaiting change review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This is the second in series of PRs adding type annotations to pyarrow and resolving #32609. It builds on top of and should be merged after #48618.
What changes are included in this PR?
This adds:
_types.pyi- Core type definitions including_stubs_typing.pyi- Internal typing protocols and helpers used across stub fileserror.pyi- Exception classes (ArrowException,ArrowInvalid,ArrowIOError, etc.)lib.pyi,io.pyi,scalar.pyi- using__getattr__to allow imports to resolve while deferring to subsequent PRsAre these changes tested?
Via CI type checks established in #48618.
Are there any user-facing changes?
Users will start seeing some minimal annotated types.