GH-50103: [C++] Missing sstream include in cpp/src/arrow/util/string_util.h#50101
Open
atupone wants to merge 2 commits into
Open
GH-50103: [C++] Missing sstream include in cpp/src/arrow/util/string_util.h#50101atupone wants to merge 2 commits into
atupone wants to merge 2 commits into
Conversation
std::unique_ptr<std::ostringstream> sstream_; require sstream. Bug raised while building with gcc-17 https://bugs.gentoo.org/976604
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
atupone
changed the title
|
|
raulcd
approved these changes
Jun 5, 2026
Member
raulcd
left a comment
raulcd
left a comment
There was a problem hiding this comment.
Thanks! Seems related to this commit on GCC:
gcc-mirror/gcc@396ad1175450
cc @pitrou
github-actions
Bot
added
awaiting merge
pitrou
reviewed
Jun 5, 2026
|
|
||
| #include <memory> | ||
| #include <ostream> | ||
| #include <sstream> |
Member
There was a problem hiding this comment.
Can we please include <iosfwd> instead?
Author
There was a problem hiding this comment.
Done. I didn't squash. Should I ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::unique_ptrstd::ostringstream sstream_; require sstream include.
Bug raised while building with gcc-17
https://bugs.gentoo.org/976604