GH-50105: [C++][Python] Fix sliced sparse union null checks#50108
Open
fenfeng9 wants to merge 1 commit into
Open
GH-50105: [C++][Python] Fix sliced sparse union null checks#50108fenfeng9 wants to merge 1 commit into
fenfeng9 wants to merge 1 commit into
Conversation
|
|
github-actions
Bot
added
Component: C++
Component: Python
awaiting review
Contributor
Author
|
By the way, there seems to be another sparse union-related bug. I'll take a closer look tomorrow, and if I can confirm it, I'll open a separate issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Sliced sparse unions could report incorrect nullness during element access.
The type id lookup used the union offset, but the child null check still used the slice-relative index.
What changes are included in this PR?
IsNullSparseUnionandArraySpan::IsNullSparseUnionindata.ccto use the parent offset when checking child nullness.Are these changes tested?
Yes.
Are there any user-facing changes?
No.