Skip to content

requirements/requirements.in: It depends on grpc >= 1.30#1489

Closed
jjardon wants to merge 3 commits into
apache:bst-1from
jjardon:jjardon/grpcio_1.37
Closed

requirements/requirements.in: It depends on grpc >= 1.30#1489
jjardon wants to merge 3 commits into
apache:bst-1from
jjardon:jjardon/grpcio_1.37

Conversation

@jjardon

@jjardon jjardon commented Aug 2, 2021

Copy link
Copy Markdown
Contributor

with older version you will get errors like this accessing the CAS:

[--:--:--][][] WARNING Failed to initialize remote https://freedesktop-sdk-cache.codethink.co.uk:11001: Received http2 header with status: 404

@juergbi

juergbi commented Aug 2, 2021

Copy link
Copy Markdown
Contributor

Is grpcio 1.37 the minimum version you've determined or is this simply a known working version? In CI even for BuildStream master we still have a minimum of 1.10 declared and we're testing with 1.34 in CI. And for the C++ library we even still test with gRPC 1.16 (Debian 10), gRPC 1.25 (CentOS 7.7 and Ubuntu 18.04) and gRPC 1.26 (Fedora 32/33), as far as I can tell.

gRPC 1.37 is fairly recent. Can this be an issue on older distros or is this a non-issue as everyone is pulling it from PyPI and there are also no indirect dependency issues?

In any case, any potential issues with old grpcio versions likely also apply to BuildStream master. And thus, this should first be fixed in master before a backport to bst-1.

@jjardon

jjardon commented Aug 2, 2021

Copy link
Copy Markdown
Contributor Author

To be fair I'm not aware of the exact version that fix the problem but I know 1.37 work correctly. Also I know is definitely a problem in fedora 34, which has grpc 1.26

What do you test in the CI exactly? We are using buildbox-casd as remote cache.

Maybe is because you require 1.34 in master? I will change this PR to relax the requirement to that version

@jjardon jjardon force-pushed the jjardon/grpcio_1.37 branch from f705119 to 1e46e14 Compare August 3, 2021 06:17
@jjardon

jjardon commented Aug 3, 2021

Copy link
Copy Markdown
Contributor Author

PR for master here (1.34 is already in requirements.txt): #1490

@jjardon jjardon changed the title requirements/requirements.in: It depends on grpc >= 1.37 requirements/requirements.in: It depends on grpc >= 1.34 Aug 3, 2021
@nanonyme

nanonyme commented Aug 3, 2021

Copy link
Copy Markdown
Contributor

@juergbi there's a requirement bump induced by RAAPI-based remote cache.

@nanonyme

nanonyme commented Aug 3, 2021

Copy link
Copy Markdown
Contributor

The Fedora version (1.26.0) at least is known not to work correctly with newer caches.

gtristan and others added 3 commits August 9, 2021 10:53
with older version you will get errors like this accessing the CAS:
[--:--:--][][] WARNING Failed to initialize remote https://freedesktop-sdk-cache.codethink.co.uk:11001: Received http2 header with status: 404
@jjardon jjardon force-pushed the jjardon/grpcio_1.37 branch from 1e46e14 to 94927ff Compare August 9, 2021 09:53
@jjardon jjardon changed the title requirements/requirements.in: It depends on grpc >= 1.34 requirements/requirements.in: It depends on grpc >= 1.30 Aug 9, 2021
@jjardon

jjardon commented Aug 9, 2021

Copy link
Copy Markdown
Contributor Author

As we do not know exactly the first version that works, I have further relaxed the requirement to 1.30, which is available in more distros (like debian)

@gtristan

Copy link
Copy Markdown
Contributor

Rebased this in #1497 and merging there

@gtristan gtristan closed this Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants