Fix findHostsForMigration never returning hosts from other clusters

[winterhazel]

Description

This PR fixes a regression introduced in #12014. Before 4.20.3, if the instance supported storage migration, the API would create a deployment plan passing the clusterId as null to also list compatible hosts from other clusters. In 4.20.3, a clusterId is always provided to the plan. Due to this, hosts from other clusters are never returned.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested by opening the migration wizard for a running instance and validating that hosts from other clusters were returned as compatible.

[winterhazel]

@blueorangutan package

[blueorangutan]

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 82.75862% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.26%. Comparing base (4244c2c) to head (f6c603b).

Files with missing lines	Patch %	Lines
...in/java/com/cloud/server/ManagementServerImpl.java	82.75%	2 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #13452   +/-   ##
=========================================
  Coverage     16.25%   16.26%           
- Complexity    13432    13439    +7     
=========================================
  Files          5667     5667           
  Lines        500670   500687   +17     
  Branches      60801    60803    +2     
=========================================
+ Hits          81397    81438   +41     
+ Misses       410165   410142   -23     
+ Partials       9108     9107    -1     

Flag	Coverage Δ
uitests	4.14% <ø> (ø)
unittests	17.12% <82.75%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18303

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[vishesh92]

Why remove srcHost from here? IMO, it would be better to pass the source host and use that instead of fetching from the db every time.

[vishesh92]

clgtm. didn't test. Only 1 change I would like to suggest is to pass the srcHost instead of fetching it from the database every time. Otherwise this can slow down the DRS plan generation when there are a lot of VMs & hosts in the cluster.