[CLOUDSTACK-10257]Create template/volume does not allow to specify HVM requirements#2437
Merged
rafaelweingartner merged 1 commit intoMar 2, 2018
Merged
Conversation
Contributor
|
and some javascript refactoring along the way 👍 |
Member
Author
|
It is not as much refactoring as it is extracting duplicated code to a common method. BTW, the JavaScript part of ACS looks like created by someone that was charging by the lines.... I have never seen so many repeated code in my whole life. |
Member
Author
|
This PR will create add the HVM option as illustrated in the following image. The option will appear in both, create template from snapshot and create template from volume buttons.
|
Member
Author
|
@khos2ow would you mind reviewing this one? |
Member
Author
|
Thanks @khos2ow. |
DaanHoogland
approved these changes
Mar 2, 2018
DaanHoogland
left a comment
DaanHoogland
left a comment
Contributor
There was a problem hiding this comment.
definitely an improvement. not the end result that will make us proud of our javascript ;)
bernardodemarco
pushed a commit
to scclouds/cloudstack
that referenced
this pull request
Jul 16, 2025
…clouds' Correção da validação de acesso nas APIs `listGuiThemes` e `destroyVirtualMachine` para considerar as permissões da API Keypair Closes apache#2437 See merge request scclouds/scclouds!1146
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating a template from a snapshot of a ROOT volume, which has a PV operating system, ACS creates the template with flag HVM=1, which may cause problems to deploy the aforementioned template in environments that do not have hosts that support HVM. When creating templates from Snapshots or volumes an option to specify if the template that is going to be created needs HVM or not should be presented.