[4.11] CLOUDSTACK-10299: UI: fix error in network listing in project mode#2464
Conversation
resmo
changed the title
| } | ||
|
|
||
| /*$.ajax({ |
There was a problem hiding this comment.
You have gone over some commented code. What about removing it?
There was a problem hiding this comment.
I didn't see a reason why to remove comments, I wanted to fix the issue. Whitespace cleanup was made by my editor automatically.
There was a problem hiding this comment.
Well.. the commented code is not used. So, there is your reason to remove it. The less "code" (lines) for our eyes to see, the better.
There was a problem hiding this comment.
I see your point. cleaning up commented out code makes sense.
|
@resmo thanks for the contributions, but I have a doubt. You say it (the PR) is aimed at 4.11, but you opened a PR against master branch. Which one do you want? |
|
@rafaelweingartner changed the base to 4.11 |
|
@blueorangutan package |
|
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
| $.ajax({ | ||
| url: createURL('listRemoteAccessVpns'), | ||
| data: { | ||
| account: g_account, |
There was a problem hiding this comment.
Is this call only used in the project view?
I mean, if I list networks and I am out of the project view, should not ACS filter by these data? Or, is it done automatically in the server side when the users is logged-in?
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1728 |
borisstoyanov
left a comment
borisstoyanov
left a comment
There was a problem hiding this comment.
@resmo Can we have some screenshots please?
|
@borisstoyanov before or after the patch? I attached the screenshot to the issue in jira. Didn't make one after the patch, as you see "nothing" (no error). |
|
@resmo both if you have. If no, new stuff is what's interesting :) |
|
Before
After
|
|
ready for review |
|
@borisstoyanov @rafaelweingartner is this merge ready? |
|
There is still one open question of mine there. It is about some parameters that were removed. I am asking if that removal can affect the loading of information for the default view (view outside of project). |
|
@rafaelweingartner I couldn't test the view with having existing remote vpns configured. But my assumption was that the api is working identically as other list apis returning the results of the current owner. |
|
Got it. I think this one is ready to be merged then. |
|
anything holding you back, @rafaelweingartner ? |
|
Nothing... I was busy with some other things. |
[4.11] CLOUDSTACK-10299: UI: fix error in network listing in project mode
5 participants
Statically passing account (and domainid) results in a conflict when in project view because projectid and account can not be used together.
Removing the 2 params. fixes the issue. (some whitespace fixes along)