Skip to content

network: Fix security groups for CentOS#2590

Merged
yadvr merged 1 commit into
apache:4.11from
shapeblue:sg-fixes-centos
Apr 23, 2018
Merged

network: Fix security groups for CentOS#2590
yadvr merged 1 commit into
apache:4.11from
shapeblue:sg-fixes-centos

Conversation

@yadvr

@yadvr yadvr commented Apr 22, 2018

Copy link
Copy Markdown
Member

On RHEL/CentOS/Fedora the bridge related sysctl rules are enabled
in kernel by default but can only be disabled. Enabling those keys
will fail, causing iptables/ebtables tables to not be created
and fails SG on CentOS. Therefore, SG does not work on CentOS.

This also fixes an integration test case, which assumes first few
tests complete within 3 minutes. In nested env the value may be large,
this increases the value to 20 minutes.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

Screenshots (if appropriate):

How Has This Been Tested?

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
    Testing
  • I have added tests to cover my changes.
  • All relevant new and existing integration tests have passed.
  • A full integration testsuite with all test that can run on my environment has passed.

On RHEL/CentOS/Fedora the bridge related sysctl rules are enabled
in kernel by default but can only be disabled. Enabling those keys
will fail, causing iptables/ebtables tables to not be created
and fails SG on CentOS.

This also fixes an integration test case, which assumes first few
tests complete within 3 minutes. In nested env the value may be large,
this increases the value to 20 minutes.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr

yadvr commented Apr 22, 2018

Copy link
Copy Markdown
Member Author

I've updated docs here:
apache/cloudstack-docs-admin@ea1edc3

@yadvr

yadvr commented Apr 22, 2018

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1966

@yadvr

yadvr commented Apr 22, 2018

Copy link
Copy Markdown
Member Author

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@wido wido left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

However, still, I think that a admin should set these values manually instead of us changing kernel parameters

@yadvr

yadvr commented Apr 23, 2018

Copy link
Copy Markdown
Member Author

Thanks, agree @wido.

@yadvr

yadvr commented Apr 23, 2018

Copy link
Copy Markdown
Member Author

I'll merge this based on travis results, manual testing (trillian tests don't do sg+centos) and code review.

@yadvr yadvr merged commit ea55a00 into apache:4.11 Apr 23, 2018
@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-2533)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 106241 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2590-t2533-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_network.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 66 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_03_vpc_privategw_restart_vpc_cleanup Failure 210.03 test_privategw_acl.py

bernardodemarco pushed a commit to scclouds/cloudstack that referenced this pull request Jul 16, 2025
… into '4.20.0.0-scclouds'

Adição da quantidade de _system_ VMs à listagem de _hosts_ na GUI

Closes apache#2590

See merge request scclouds/scclouds!1171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants