Skip to content

README: Ho ho ho!#3102

Merged
yadvr merged 1 commit into
apache:masterfrom
shapeblue:xmas-2019
Dec 20, 2018
Merged

README: Ho ho ho!#3102
yadvr merged 1 commit into
apache:masterfrom
shapeblue:xmas-2019

Conversation

@yadvr

@yadvr yadvr commented Dec 18, 2018

Copy link
Copy Markdown
Member

Merry Christmas and happy holidays!

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr

yadvr commented Dec 18, 2018

Copy link
Copy Markdown
Member Author

screenshot from 2018-12-19 02-53-41

@ustcweizhou

Copy link
Copy Markdown
Contributor

merry xmas and happy new year!

@bwsw

bwsw commented Dec 18, 2018

Copy link
Copy Markdown
Contributor

@rhtyd Thank you! Merry Christmas as well)

@yadvr

yadvr commented Dec 18, 2018

Copy link
Copy Markdown
Member Author

Can we have some LGTMs, I checked the Travis test failures were not caused by this PR ;)

@syed

syed commented Dec 18, 2018

Copy link
Copy Markdown
Contributor

LGTM! Merry Christmas and Happy new year everyone!

@nvazquez

Copy link
Copy Markdown
Contributor

LGTM. Merry Christmas and Happy New Year guys! 🎉

@khos2ow

khos2ow commented Dec 19, 2018

Copy link
Copy Markdown
Contributor

LGTM and merry Christmas everyone!
I do have a small comment though, why the name of branch is xmas-2019? 😉

@anuragaw

Copy link
Copy Markdown
Contributor

LGTM. A very merry Christmas and happy new year ahead everyone!

@dhlaluku

Copy link
Copy Markdown
Contributor

LGTM. Merry Christmas and Happy New Year to everyone.

@glennwagner

Copy link
Copy Markdown

LGTM , Merry Christmas everyone, Happy new year

@svenvogel

Copy link
Copy Markdown
Contributor

LGTM! Merry Christmas!

@andrijapanic-dont-use-this-one

Copy link
Copy Markdown

+1
Merry Christmas and Happy New year to all :)

@borisstoyanov borisstoyanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! Happy holidays all!

@NuxRo

NuxRo commented Dec 19, 2018

Copy link
Copy Markdown
Contributor

Fill your bellies and be merry! Ho ho ho :)

@PaulAngus

Copy link
Copy Markdown
Member

+1 Merry Christmas everyone!
image

@RPDiep

RPDiep commented Dec 19, 2018

Copy link
Copy Markdown
Contributor

LGTM, Happy holidays and have a wonderful 2019!

@DagSonsteboSB

Copy link
Copy Markdown

LGTM - happy holidays and all the best for 2019!

@yadvr

yadvr commented Dec 19, 2018

Copy link
Copy Markdown
Member Author

I do have a small comment though, why the name of branch is xmas-2019?
@khos2ow well it's about Christmas time and 2019 new year!

@andrijapanicsb

Copy link
Copy Markdown
Contributor

I do have a small comment though, why the name of branch is xmas-2019?
@khos2ow well it's about Christmas time and 2019 new year!

For me xmas is on 7th January 2019 - so "works on my machine" 🕺

@pdion891

Copy link
Copy Markdown
Contributor

Best PR ever, +1

Enjoy holidays ! :-)

@milamberspace

Copy link
Copy Markdown
Contributor

LGTM
Thanks and Happy new year!

@GabrielBrascher GabrielBrascher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @rhtyd!
Merry Christmas and a great 2019 to all! 🎄 🎅 🎈 🎉 ☁️ 🐵 🏆

@resmo

resmo commented Dec 19, 2018

Copy link
Copy Markdown
Member

@msinhore

Copy link
Copy Markdown

Merry Christmas and Happy new year guys!

@yadvr

yadvr commented Dec 20, 2018

Copy link
Copy Markdown
Member Author

We're in violent agreement, let's merge!

@yadvr yadvr merged commit 5067d56 into apache:master Dec 20, 2018
@yadvr yadvr deleted the xmas-2019 branch December 20, 2018 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.