VmwareStorageLayoutHelper throws StackOverflowError fix

[dhlaluku]

The static method syncVolumeToRootFolder() from VmwareStorageLayoutHelper.java:146 has been incorrectly called and leads to an infinite recursive call that ends up in a StackOverflowError. This PR fixes this.
public static void syncVolumeToRootFolder(DatacenterMO dcMo, DatastoreMO ds, String vmdkName, String vmName) throws Exception { syncVolumeToRootFolder(dcMo, ds, vmdkName, null); } -> public static void syncVolumeToRootFolder(DatacenterMO dcMo, DatastoreMO ds, String vmdkName, String vmName) throws Exception { syncVolumeToRootFolder(dcMo, ds, vmdkName, vmName, null); }

Description

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

[dhlaluku]

@anuragaw @rafaelweingartner @DaanHoogland @GabrielBrascher please have a look at this.

[dhlaluku]

@SudharmaJain please review

[dhlaluku]

@blueorangutan package

[blueorangutan]

@dhlaluku a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2498

[dhlaluku]

@blueorangutan test centos7 vmware-65

[blueorangutan]

@dhlaluku a Trillian-Jenkins test job (centos7 mgmt + vmware-65) has been kicked to run smoke tests

[yadvr]

@blueorangutan test centos7 vmware-65

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-3268)
Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29378 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3105-t3268-vmware-65.zip
Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 68 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_nic_secondaryip_add_remove	Error	73.92	test_multipleips_per_nic.py
test_04_rvpc_network_garbage_collector_nics	Failure	531.86	test_vpc_redundant.py

[anuragaw]

Code LGTM.
(Talk about silly mistakes)

[yadvr]

LGTM, @dhlaluku since this is a bugfix do you think 4.11 can benefit from it?

[dhlaluku]

@rhtyd I checked 4.11 and it should not be affected by this, but I do not see any reason why we should not apply this to 4.11.

[yadvr]

@dhlaluku in that case please change the base branch to 4.11 and rebase your PR branch against 4.11

[dhlaluku]

@blueorangutan package

[blueorangutan]

@dhlaluku a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[dhlaluku]

@rhtyd thanks, done.

@dhlaluku in that case please change the base branch to 4.11 and rebase your PR branch against 4.11

@rhtyd done

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2513

[dhlaluku]

@blueorangutan package

[blueorangutan]

@dhlaluku a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2514

[dhlaluku]

@blueorangutan test centos7 vmware-65

[blueorangutan]

@dhlaluku a Trillian-Jenkins test job (centos7 mgmt + vmware-65) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-3297)
Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30560 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3105-t3297-vmware-65.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 67 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_05_rvpc_multi_tiers	Failure	455.35	test_vpc_redundant.py
test_05_rvpc_multi_tiers	Error	486.71	test_vpc_redundant.py

[dhlaluku]

@rhtyd can we merge this?