Rework for destroy VM with volumes UI#3120
Merged
GabrielBrascher merged 3 commits intoJan 9, 2019
Merged
Conversation
dhlaluku
changed the title
GabrielBrascher
approved these changes
Jan 7, 2019
GabrielBrascher
left a comment
GabrielBrascher
left a comment
Member
There was a problem hiding this comment.
Thanks, @dhlaluku! Code and UI LGTM.
dhlaluku
changed the title
Contributor
Author
|
@rafaelweingartner @wido any suggestions with this? Otherwise, I think we can merge it since it is rather a very small rework. /CC @DaanHoogland @andrijapanic @rhtyd |
Member
|
This one looks ready for merge indeed. Simple UI rework that has been tested (screenshots). |
Contributor
|
@blueorangutan package |
|
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2536 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the redundant checkbox to tick if a user wants to delete volumes when destroying VMs
#2793
Types of changes
Screenshots (if appropriate):
Currently
Rework
How Has This Been Tested?