Skip to content

Fix no "data-server" DNS record for VPC router #4873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yadvr merged 1 commit into from
Apr 5, 2021
Merged

Fix no "data-server" DNS record for VPC router #4873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions systemvm/debian/etc/vpcdnsmasq.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,3 +462,4 @@ log-facility=/var/log/dnsmasq.log
conf-dir=/etc/dnsmasq.d

dhcp-optsfile=/etc/dhcpopts.txt
localise-queries
3 changes: 3 additions & 0 deletions systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,9 @@ def configure_server(self):
listen_address.append(gateway)
else:
listen_address.append(ip)
# Add localized "data-server" records in /etc/hosts for VPC routers
if self.config.is_vpc():
self.add_host(gateway, "%s data-server" % CsHelper.get_hostname())

@DaanHoogland DaanHoogland Mar 29, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can only work if we know for sure that CsHelper.get_hostname() gives an ip address and no hostname, are we?

@aleskxyz aleskxyz Mar 29, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can only work if we know for sure that CsHelper.get_hostname() gives an ip address and no hostname, are we?

@DaanHoogland
CsHelper.get_hostname() gives the hostname of virtual router. As you can see in screenshot, 'r-24-VM' is the hostname. So it should return hostname, not IP.

@DaanHoogland DaanHoogland Mar 30, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, never mind, I mis-interpreted the semantics of add_host(). no ip needed in that parameter, a (list of) hosts-name(s) is fine.

idx += 1

# Listen Address
Expand Down