Skip to content

UI: Restored the Basic Networking#4882

Merged
yadvr merged 3 commits into
apache:4.15from
utchoang:feature/zone-restore-basic-network
Apr 1, 2021
Merged

UI: Restored the Basic Networking#4882
yadvr merged 3 commits into
apache:4.15from
utchoang:feature/zone-restore-basic-network

Conversation

@utchoang

@utchoang utchoang commented Mar 31, 2021 •
edited
Loading

Copy link
Copy Markdown

Description

Fixes #4863

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

image

How Has This Been Tested?

@utchoang utchoang changed the base branch from master to 4.15 March 31, 2021 02:31
@yadvr yadvr requested a review from davidjumani March 31, 2021 02:32
@yadvr yadvr added this to the 4.15.1.0 milestone Mar 31, 2021
@yadvr yadvr requested a review from PaulAngus March 31, 2021 02:32
@utchoang utchoang requested review from shwstppr and yadvr March 31, 2021 02:32
@yadvr yadvr removed their request for review March 31, 2021 02:32
@utchoang

utchoang commented Mar 31, 2021

Copy link
Copy Markdown
Author

@blueorangutan ui

@blueorangutan

blueorangutan commented Mar 31, 2021

Copy link
Copy Markdown

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Mar 31, 2021

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4882 (SL-JID-80)

yadvr
yadvr approved these changes Apr 1, 2021
View reviewed changes

@yadvr yadvr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tested basic zone deployment using QA env: http://qa.cloudstack.cloud:8080/client/pr/4882/#/zone/50803617-5cc7-4754-b5ab-0658b53ad239

Was able to deploy dummy VM

@shwstppr

shwstppr commented Apr 1, 2021

Copy link
Copy Markdown
Contributor

Looks good. @utchoang can you please resolve conflict

@shwstppr

shwstppr commented Apr 1, 2021

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

blueorangutan commented Apr 1, 2021

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Apr 1, 2021

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4882 (SL-JID-84)

@yadvr yadvr merged commit 575e18c into apache:4.15 Apr 1, 2021
This was referenced Apr 1, 2021
Closed
Closed
@utchoang utchoang deleted the feature/zone-restore-basic-network branch April 1, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes
@shwstppr shwstppr shwstppr approved these changes
@davidjumani davidjumani Awaiting requested review from davidjumani
@PaulAngus PaulAngus Awaiting requested review from PaulAngus

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.15.1.0

Development

Successfully merging this pull request may close these issues.

Basic Networking needs to be restored - Advanced networks with security groups is not the same.

4 participants

@utchoang @blueorangutan @shwstppr @yadvr