no axis by DaanHoogland · Pull Request #5993 · apache/cloudstack

DaanHoogland · 2022-02-14T13:42:55Z

Description

This PR replaces axis with axis2. Surrisingly almost everything compiled.Only the F5 plugin, relying on iControl, for which the latest version still requires axis, cannot. Needs extensive testing if at all it would work like this.

Fixes: #5964

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

DaanHoogland · 2022-02-14T16:04:06Z

@blueorangutan package

blueorangutan · 2022-02-14T16:05:03Z

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-02-14T16:42:18Z

Packaging result: ✖️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2602

sureshanaparti · 2022-02-15T06:03:07Z

@blueorangutan package

blueorangutan · 2022-02-15T06:05:02Z

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-02-15T06:52:39Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2610

sureshanaparti · 2022-02-15T07:59:57Z

@blueorangutan test

blueorangutan · 2022-02-15T08:01:03Z

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

DaanHoogland · 2022-02-15T10:17:26Z

@blueorangutan test centos7 vmware-70u3

blueorangutan · 2022-02-15T10:18:03Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-70u3) has been kicked to run smoke tests

GabrielBrascher

LGTM
(waiting for tests, but build at least worked fine)

nvazquez · 2022-02-15T18:09:38Z

        </dependency>
-        <dependency>
-            <groupId>org.apache.axis</groupId>
-            <artifactId>axis</artifactId>


I'm not sure about this, why not upgrading to axis2 here? Worried about this: https://github.com/apache/cloudstack/blob/main/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareContextFactory.java#L48 and https://github.com/apache/cloudstack/blob/main/plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareSecondaryStorageContextFactory.java#L35

From https://axis.apache.org/axis2/java/core/docs/migration.html doesn't look like this would cause an issue. However, this is raising eyebrows - https://java-user.axis.apache.narkive.com/86NmaQ8j/axis2-accepting-self-signed-certificate-from-the-server
I'm wondering where that certificate ignoring is affecting communication, esp when smoketests have passed.

blueorangutan · 2022-02-15T20:43:33Z

Trillian test result (tid-3334)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44313 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5993-t3334-kvm-centos7.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_07_deploy_kubernetes_ha_cluster	`Failure`	3602.19	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	0.05	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	0.04	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	79.53	test_kubernetes_clusters.py

blueorangutan · 2022-02-16T00:42:01Z

Trillian test result (tid-3341)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 50220 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5993-t3341-vmware-70u3.zip
Smoke tests completed. 89 look OK, 3 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_invalid_upgrade_kubernetes_cluster	`Failure`	3605.49	test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster	`Failure`	3603.78	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	0.06	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	`Failure`	0.04	test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster	`Failure`	0.04	test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster	`Failure`	0.04	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	`Failure`	0.04	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	0.04	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	0.04	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	47.09	test_kubernetes_clusters.py
test_01_offline_migrate_VM_and_root_volume	`Error`	88.93	test_vm_life_cycle.py
test_03_live_migrate_VM_with_two_data_disks	`Error`	61.54	test_vm_life_cycle.py
test_06_disk_offering_strictness_false	`Error`	159.91	test_service_offerings.py

DaanHoogland · 2022-02-21T15:33:10Z

@blueorangutan test centos7 vmware-67u3

blueorangutan · 2022-02-21T15:34:03Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

DaanHoogland · 2022-02-25T10:36:21Z

@blueorangutan test centos7 vmware-67u3

blueorangutan · 2022-02-25T10:37:02Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan · 2022-02-26T00:35:11Z

Trillian test result (tid-3436)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49090 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5993-t3436-vmware-67u3.zip
Smoke tests completed. 89 look OK, 3 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_invalid_upgrade_kubernetes_cluster	`Failure`	3624.93	test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster	`Failure`	3623.35	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	0.05	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	`Failure`	0.04	test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster	`Failure`	0.04	test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster	`Failure`	0.03	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	`Failure`	0.04	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	0.04	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	0.04	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	46.14	test_kubernetes_clusters.py
test_01_offline_migrate_VM_and_root_volume	`Error`	88.94	test_vm_life_cycle.py
test_02_offline_migrate_VM_with_two_data_disks	`Error`	57.17	test_vm_life_cycle.py
test_03_live_migrate_VM_with_two_data_disks	`Error`	60.34	test_vm_life_cycle.py
test_06_disk_offering_strictness_false	`Error`	142.36	test_service_offerings.py

nvazquez · 2022-03-03T16:11:35Z

@blueorangutan package

blueorangutan · 2022-03-03T16:12:03Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-03-03T17:12:09Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2755

nvazquez · 2022-03-03T17:38:20Z

@blueorangutan test centos7 vmware-67u3

blueorangutan · 2022-03-03T17:39:03Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

nvazquez · 2022-03-06T13:10:07Z

@blueorangutan package

blueorangutan · 2022-03-06T13:11:02Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-03-06T14:01:40Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2775

nvazquez · 2022-03-06T14:29:09Z

@blueorangutan test centos7 vmware-67u3

blueorangutan · 2022-03-06T14:30:03Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan · 2022-03-07T00:24:14Z

Trillian test result (tid-3510)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34513 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5993-t3510-vmware-67u3.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

nvazquez · 2022-03-07T00:35:03Z

Hi @DaanHoogland please advise if manual testing is needed (and what to test) on this PR or is ready

yadvr · 2022-03-07T09:42:00Z

I suppose we won't be able to test srx, f5 and all those plugins. It's possible they don't work or have never worked. We can however only test Vmware.

@blueorangutan test matrix

blueorangutan · 2022-03-07T09:43:02Z

@rohityadavcloud a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2022-03-07T18:51:40Z

Trillian test result (tid-3515)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31480 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5993-t3515-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2022-03-07T19:42:45Z

Trillian test result (tid-3514)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34664 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5993-t3514-xenserver-71.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2022-03-07T20:16:10Z

Trillian test result (tid-3516)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36789 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5993-t3516-vmware-65u2.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

nvazquez

LGTM - manually tested VMware working fine

no axis

0049bc4

DaanHoogland closed this Feb 14, 2022

DaanHoogland reopened this Feb 14, 2022

remove f5 from ui

4eb482d

apache deleted a comment from blueorangutan Feb 14, 2022

sureshanaparti added the type:security label Feb 15, 2022

sureshanaparti added this to the 4.17.0.0 milestone Feb 15, 2022

GabrielBrascher approved these changes Feb 15, 2022

View reviewed changes

nvazquez reviewed Feb 15, 2022

View reviewed changes

yadvr approved these changes Feb 25, 2022

View reviewed changes

yadvr approved these changes Mar 7, 2022

View reviewed changes

nvazquez approved these changes Mar 8, 2022

View reviewed changes

nvazquez merged commit b014617 into apache:main Mar 8, 2022

nvazquez mentioned this pull request Mar 8, 2022

upgrade axis due to security issues #6068

Closed

Conversation

DaanHoogland commented Feb 14, 2022

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

DaanHoogland commented Feb 14, 2022

Uh oh!

blueorangutan commented Feb 14, 2022

Uh oh!

blueorangutan commented Feb 14, 2022

Uh oh!

sureshanaparti commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

sureshanaparti commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

DaanHoogland commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

GabrielBrascher left a comment

Choose a reason for hiding this comment

Uh oh!

nvazquez Feb 15, 2022

Choose a reason for hiding this comment

Uh oh!

yadvr Mar 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 16, 2022

Uh oh!

DaanHoogland commented Feb 21, 2022

Uh oh!

blueorangutan commented Feb 21, 2022

Uh oh!

DaanHoogland commented Feb 25, 2022

Uh oh!

blueorangutan commented Feb 25, 2022

Uh oh!

blueorangutan commented Feb 26, 2022

Uh oh!

nvazquez commented Mar 3, 2022

Uh oh!

blueorangutan commented Mar 3, 2022

Uh oh!

blueorangutan commented Mar 3, 2022

Uh oh!

nvazquez commented Mar 3, 2022

Uh oh!

blueorangutan commented Mar 3, 2022

Uh oh!

nvazquez commented Mar 6, 2022

Uh oh!

blueorangutan commented Mar 6, 2022

Uh oh!

blueorangutan commented Mar 6, 2022

Uh oh!

nvazquez commented Mar 6, 2022

Uh oh!

blueorangutan commented Mar 6, 2022

Uh oh!

blueorangutan commented Mar 7, 2022

Uh oh!

nvazquez commented Mar 7, 2022

Uh oh!

yadvr commented Mar 7, 2022

Uh oh!

yadvr Mar 7, 2022 •

edited

Loading