Skip to content

Travis - fix test failures observed#6119

Merged
nvazquez merged 1 commit into
apache:4.16from
shapeblue:fix-travis-failures
Mar 16, 2022
Merged

Travis - fix test failures observed#6119
nvazquez merged 1 commit into
apache:4.16from
shapeblue:fix-travis-failures

Conversation

@Pearl1594

Copy link
Copy Markdown
Contributor

Description

This PR fixes a subset of travis test failures as indicated in: #6115
They include:
component/test_acl_sharednetwork_deployVM-impersonation:

  • test_deployVM_in_sharedNetwork_as_regularuser_scope_all_anotherusersamedomain
  • test_deployVM_in_sharedNetwork_as_regularuser_scope_all_crossdomain

component/test_acl_isolatednetwork

  • test_19_deployvm_user_foruserinsamedomain
  • test_20_deployvm_user_foruserincrossdomain
  • test_29_restartNetwork_user_foruserinsamedomain
  • test_30_restartNetwork_user_foruserinotherdomain

component/test_acl_isolatednetwork_delete

  • test_deleteNetwork_user_foruserinotherdomain
  • test_deleteNetwork_user_foruserinsamedomain

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@Pearl1594 Pearl1594 added this to the 4.17.0.0 milestone Mar 15, 2022
@Pearl1594 Pearl1594 linked an issue Mar 15, 2022 that may be closed by this pull request
@weizhouapache

Copy link
Copy Markdown
Member

@Pearl1594
since the travis test fails on 4.16, can you re-target to 4.16 ?

as we discussed internally, it would be better to create all bug fixes for LTS version then merge forward to main branch.

@Pearl1594

Copy link
Copy Markdown
Contributor Author

Sure @weizhouapache I'll target this PR against 4.16. Thanks.

@Pearl1594 Pearl1594 changed the base branch from main to 4.16 March 15, 2022 10:27
@Pearl1594 Pearl1594 changed the base branch from 4.16 to main March 15, 2022 10:28
@Pearl1594 Pearl1594 force-pushed the fix-travis-failures branch from 25807fa to 3bf8683 Compare March 15, 2022 11:59
@Pearl1594 Pearl1594 changed the base branch from main to 4.16 March 15, 2022 11:59
@nvazquez

Copy link
Copy Markdown
Contributor

Merging based on approvals and Travis test results since this PR fixes them

@nvazquez nvazquez merged commit 75b5417 into apache:4.16 Mar 16, 2022
@nvazquez

Copy link
Copy Markdown
Contributor

@Pearl1594 given #6126, does this PR need to be reverted as well?

@Pearl1594

Pearl1594 commented Mar 17, 2022

Copy link
Copy Markdown
Contributor Author

These test failures didn't pertain to the changes made in #6126 @nvazquez

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

travis tests failed in 4.16/main

4 participants