Skip to content

Fix listofferings failing for usrs and failin travis tests#6125

Closed
davidjumani wants to merge 2 commits into
apache:mainfrom
shapeblue:fix-list-by-id
Closed

Fix listofferings failing for usrs and failin travis tests#6125
davidjumani wants to merge 2 commits into
apache:mainfrom
shapeblue:fix-list-by-id

Conversation

@davidjumani

@davidjumani davidjumani commented Mar 16, 2022

Copy link
Copy Markdown
Contributor

Description

This PR Fixes the following :

  • Sets isrecursive=false for users when listall=true by default to prevent any permission issues when listing resources as a user
  • Failing travis tests

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

How Has This Been Tested?

$ nosetests --with-xunit --xunit-file=results.xml --with-marvin --marvin-config=setup/dev/advanced.cfg  -s -a tags=mine --hypervisor=simulator test/integration/component/test_acl_listvm.py

=== TestName: test_listVM_by_id_as_domainadmin_ownedbyusersinsubdomain2 | Status : SUCCESS ===

=== TestName: test_listVM_by_id_as_domainadmin_ownedbyusersnotindomain | Status : SUCCESS ===



$ nosetests --with-xunit --xunit-file=results.xml --with-marvin --marvin-config=setup/dev/advanced.cfg  -s -a tags=mine --hypervisor=simulator test/integration/component/test_acl_listsnapshot.py

=== TestName: test_listSnapshot_by_id_as_domainadmin_ownedbyusersinsubdomain2 | Status : SUCCESS ===

=== TestName: test_listSnapshot_by_id_as_domainadmin_ownedbyusersnotindomain | Status : SUCCESS ===


@davidjumani

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2900

@davidjumani

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@davidjumani

Copy link
Copy Markdown
Contributor Author

Closing in favour of #6126

@yadvr yadvr removed this from the 4.17.0.0 milestone Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants