Oauth2 integration with CloudStack by harikrishna-patnala · Pull Request #7996 · apache/cloudstack

harikrishna-patnala · 2023-09-25T08:03:11Z

Description

OAuth2, the industry-standard authorization or authentication framework, simplifies the process of
granting access to resources. CloudStack supports OAuth2 authentication wherein users can login into
CloudStack without using username and password. CloudStack currently supports Google and Github providers.
Other OAuth2 providers can be easily integrated with CloudStack using its plugin framework.

The login page when the OAuth2 is enabled and corresponding providers are configured.

"OAuth configuration" sub-section is added under "Configuration" where admins can register the corresponding
OAuth providers.

more details are in the doc PR apache/cloudstack-documentation#351

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

codecov · 2023-09-25T08:15:21Z

Codecov Report

Merging #7996 (8137993) into main (bd52fa8) will decrease coverage by 0.59%.
Report is 1 commits behind head on main.
The diff coverage is 32.61%.

@@             Coverage Diff              @@
##               main    #7996      +/-   ##
============================================
- Coverage     29.20%   28.62%   -0.59%     
+ Complexity    30891    30293     -598     
============================================
  Files          5150     5165      +15     
  Lines        363420   364111     +691     
  Branches      53230    53306      +76     
============================================
- Hits         106144   104210    -1934     
- Misses       242730   245505    +2775     
+ Partials      14546    14396     -150

Flag	Coverage Δ
simulator-marvin-tests	`24.44% <8.58%> (-0.81%)`	⬇️
uitests	`4.53% <1.22%> (-0.02%)`	⬇️
unit-tests	`14.74% <38.87%> (+0.04%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
api/src/main/java/com/cloud/user/User.java	`100.00% <100.00%> (ø)`
...n/java/org/apache/cloudstack/api/ApiConstants.java	`40.90% <ø> (ø)`
...tack/api/command/user/ssh/CreateSSHKeyPairCmd.java	`87.50% <ø> (ø)`
...ack/api/command/user/userdata/ListUserDataCmd.java	`100.00% <ø> (ø)`
...api/command/user/userdata/RegisterUserDataCmd.java	`72.00% <ø> (ø)`
...rg/apache/cloudstack/oauth2/OAuth2AuthManager.java	`100.00% <100.00%> (ø)`
...m/cloud/api/auth/APIAuthenticationManagerImpl.java	`81.39% <ø> (ø)`
ui/src/components/view/ListView.vue	`16.75% <ø> (ø)`
ui/src/config/section/config.js	`0.00% <ø> (ø)`
ui/src/store/mutation-types.js	`100.00% <100.00%> (ø)`
... and 23 more

... and 166 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

harikrishna-patnala · 2023-09-27T09:33:10Z

@blueorangutan package

blueorangutan · 2023-09-27T09:34:03Z

@harikrishna-patnala a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-09-27T10:02:03Z

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 7122

GutoVeronezi · 2023-09-27T11:02:05Z

@harikrishna-patnala, do you have any documentation/specification/description of the workflow implemented?

harikrishna-patnala · 2023-09-28T09:33:18Z

@blueorangutan package

blueorangutan · 2023-09-28T09:34:03Z

@harikrishna-patnala a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-09-28T10:05:43Z

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 7155

harikrishna-patnala · 2023-09-29T09:31:01Z

@harikrishna-patnala, do you have any documentation/specification/description of the workflow implemented?

updated the description and raised a doc PR, please check here apache/cloudstack-documentation#351

harikrishna-patnala · 2023-09-29T11:09:30Z

@blueorangutan package

blueorangutan · 2023-09-29T11:10:03Z

@harikrishna-patnala a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

harikrishna-patnala · 2023-09-29T12:30:42Z

@blueorangutan package

blueorangutan · 2023-09-29T12:32:03Z

@harikrishna-patnala a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-09-29T13:32:20Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7174

harikrishna-patnala · 2023-10-30T10:38:30Z

@blueorangutan package

blueorangutan · 2023-10-30T10:40:03Z

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

DaanHoogland · 2023-10-30T10:44:40Z

@harikrishna-patnala @rohityadavcloud this is ready (for review/merge) is it?

blueorangutan · 2023-10-30T11:35:39Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7565

DaanHoogland · 2023-10-30T11:51:07Z

@blueorangutan test

DaanHoogland · 2023-10-30T11:51:56Z

@shwstppr are all your concerns met?

blueorangutan · 2023-10-30T11:52:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

yadvr · 2023-10-30T11:53:31Z

@DaanHoogland - this needs new pkgs due to changes after last pkg job

@blueorangutan package

blueorangutan · 2023-10-30T11:54:03Z

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-10-30T11:58:28Z

[SF] Trillian Build Failed (tid-8161)

blueorangutan · 2023-10-30T12:54:43Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7566

DaanHoogland · 2023-10-30T13:24:17Z

@blueorangutan test alma9 kvm-alma9

blueorangutan · 2023-10-30T13:26:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

shwstppr

Code LGTM

blueorangutan · 2023-10-31T02:31:17Z

[SF] Trillian test result (tid-8166)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 45496 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7996-t8166-kvm-alma9.zip
Smoke tests completed. 115 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

boring-cyborg Bot added component:api component:build component:networking labels Sep 25, 2023

harikrishna-patnala requested a review from kishankavala September 25, 2023 10:04

DaanHoogland self-assigned this Sep 27, 2023

DaanHoogland reviewed Sep 27, 2023

View reviewed changes

DaanHoogland closed this Sep 28, 2023

DaanHoogland reopened this Sep 28, 2023

harikrishna-patnala force-pushed the oauth branch from bd82226 to 8742d40 Compare September 28, 2023 17:08

apache deleted a comment from blueorangutan Sep 28, 2023

shwstppr reviewed Sep 29, 2023

View reviewed changes

Comment thread ui/src/utils/plugins.js Outdated

harikrishna-patnala mentioned this pull request Sep 29, 2023

OAuth 2.0 integration apache/cloudstack-documentation#351

Merged

shwstppr added this to the 4.19.0.0 milestone Sep 29, 2023

DaanHoogland closed this Sep 29, 2023

DaanHoogland reopened this Sep 29, 2023

harikrishna-patnala added 8 commits October 30, 2023 16:06

Imporved version of login page

32dee84

Added update option

83a0dbb

Added new API to gen_toc.py

aa7fa3e

Added more unit tests

805cc98

Fix lint issues

8154ce4

Fixed the oauth_provider table schema

bc899e7

Added edit option

88f7b00

Add name in the provider response

c1c75a8

harikrishna-patnala force-pushed the oauth branch from e639dea to c1c75a8 Compare October 30, 2023 10:37

github-actions Bot removed the status:has-conflicts label Oct 30, 2023

harikrishna-patnala marked this pull request as ready for review October 30, 2023 10:48

Move enable column to front

8137993

shwstppr approved these changes Oct 30, 2023

View reviewed changes

shwstppr merged commit 235e4fe into apache:main Oct 31, 2023

DaanHoogland deleted the oauth branch November 1, 2023 14:16

DaanHoogland removed their assignment Nov 16, 2023

Uh oh!

Conversation

harikrishna-patnala commented Sep 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

codecov Bot commented Sep 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

harikrishna-patnala commented Sep 27, 2023

Uh oh!

blueorangutan commented Sep 27, 2023

Uh oh!

blueorangutan commented Sep 27, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GutoVeronezi commented Sep 27, 2023

Uh oh!

harikrishna-patnala commented Sep 28, 2023

Uh oh!

blueorangutan commented Sep 28, 2023

Uh oh!

blueorangutan commented Sep 28, 2023

Uh oh!

Uh oh!

harikrishna-patnala commented Sep 29, 2023

Uh oh!

harikrishna-patnala commented Sep 29, 2023

Uh oh!

blueorangutan commented Sep 29, 2023

Uh oh!

harikrishna-patnala commented Sep 29, 2023

Uh oh!

blueorangutan commented Sep 29, 2023

Uh oh!

blueorangutan commented Sep 29, 2023

Uh oh!

harikrishna-patnala commented Oct 30, 2023

Uh oh!

blueorangutan commented Oct 30, 2023

Uh oh!

DaanHoogland commented Oct 30, 2023

Uh oh!

blueorangutan commented Oct 30, 2023

Uh oh!

DaanHoogland commented Oct 30, 2023

Uh oh!

DaanHoogland commented Oct 30, 2023

Uh oh!

blueorangutan commented Oct 30, 2023

Uh oh!

yadvr commented Oct 30, 2023

Uh oh!

blueorangutan commented Oct 30, 2023

Uh oh!

blueorangutan commented Oct 30, 2023

Uh oh!

blueorangutan commented Oct 30, 2023

Uh oh!

DaanHoogland commented Oct 30, 2023

Uh oh!

blueorangutan commented Oct 30, 2023

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Oct 31, 2023

Uh oh!

Reviewers

harikrishna-patnala commented Sep 25, 2023 •

edited

Loading

codecov Bot commented Sep 25, 2023 •

edited

Loading