Parse ALTER USER as a synonym for ALTER ROLE#2374
Open
LucaCappelletti94 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PostgreSQL,
ALTER USERis an alternate spelling ofALTER ROLEand accepts the same option syntax (WITH SUPERUSER,PASSWORD '...',CONNECTION LIMIT n,RENAME TO ...,SET/RESET parameter, etc.). The parser previously routed every dialect'sALTER USERto the Snowflake-specificparse_alter_user, which rejected all of these PostgreSQL forms.This adds a
supports_alter_user_as_alter_roledialect hook (default false, true for PostgreSQL). When set,ALTER USERdispatches to the existingparse_alter_rolepath and produces aStatement::AlterRole, since the two are semantically identical in PostgreSQL. All other dialects keep the Snowflake behavior unchanged. The shared SnowflakeALTER USERtest is scoped to dialects that do not enable the new hook.Reference: https://www.postgresql.org/docs/current/sql-alteruser.html