Accept CREATE SEQUENCE options in any order - #2414
Open
LucaCappelletti94 wants to merge 1 commit into
Open
Conversation
LucaCappelletti94
changed the title
CREATE SEQUENCE options in any order
LucaCappelletti94
marked this pull request as ready for review
July 30, 2026 16:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CREATE SEQUENCEoptions were parsed by a fixed chain of independent if blocks, one per option, so only a single order was accepted.CREATE SEQUENCE s INCREMENT BY 1 START WITH 1parsed, butCREATE SEQUENCE s START WITH 1 INCREMENT BY 1left theINCREMENTkeyword unconsumed and failed withExpected: end of statement. PostgreSQL treats these as an unordered list.Therefore, following the same pattern we used in other methods,
parse_create_sequence_optionsnow loops, dispatching on whichever option keyword comes next and breaking when none matches, and rejects repeated options. Options are recorded in the order written, so Display round-trips the input unchanged.