Skip to content

chore: remove unnecessary test helpers#13317

Merged
alamb merged 2 commits into
apache:mainfrom
findepi:findepi/chore-remove-unnecessary-test-helpers-f3abc1
Nov 17, 2024
Merged

chore: remove unnecessary test helpers#13317
alamb merged 2 commits into
apache:mainfrom
findepi:findepi/chore-remove-unnecessary-test-helpers-f3abc1

Conversation

@findepi

@findepi findepi commented Nov 8, 2024

Copy link
Copy Markdown
Member

@github-actions github-actions Bot added the optimizer Optimizer rules label Nov 8, 2024

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @findepi -- this looks great. It just needs a cargo fmt and merge up from main and I think it will be good to merge 🙏

@alamb

alamb commented Nov 14, 2024

Copy link
Copy Markdown
Contributor

I tried to fix the CI but I don't have permissions to push to your fork:

(venv) andrewlamb@Andrews-MBP-2:~/Software/datafusion2$ git push -u
Enumerating objects: 13, done.
Counting objects: 100% (13/13), done.
Delta compression using up to 16 threads
Compressing objects: 100% (7/7), done.
Writing objects: 100% (7/7), 706 bytes | 706.00 KiB/s, done.
Total 7 (delta 5), reused 0 (delta 0), pack-reused 0 (from 0)
remote: Resolving deltas: 100% (5/5), completed with 5 local objects.
To github.com:findepi/datafusion.git
 ! [remote rejected]     findepi/chore-remove-unnecessary-test-helpers-f3abc1 -> findepi/chore-remove-unnecessary-test-helpers-f3abc1 (permission denied)
error: failed to push some refs to 'github.com:findepi/datafusion.git'

@findepi

findepi commented Nov 16, 2024

Copy link
Copy Markdown
Member Author

thank you @alamb !

@alamb

alamb commented Nov 17, 2024

Copy link
Copy Markdown
Contributor

I restarted the vendored code CI check as it seems it was due to a network error

@alamb alamb merged commit e3c4541 into apache:main Nov 17, 2024
@alamb

alamb commented Nov 17, 2024

Copy link
Copy Markdown
Contributor

🚀

@findepi findepi deleted the findepi/chore-remove-unnecessary-test-helpers-f3abc1 branch November 17, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

optimizer Optimizer rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants