minor(test): cover partially ordered aggregate spilling - #23947
Merged
2010YOUY01 merged 2 commits intoJul 30, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23947 +/- ##
=======================================
Coverage 80.69% 80.70%
=======================================
Files 1095 1095
Lines 372626 372554 -72
Branches 372626 372554 -72
=======================================
- Hits 300700 300658 -42
+ Misses 53978 53926 -52
- Partials 17948 17970 +22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2010YOUY01
approved these changes
Jul 29, 2026
2010YOUY01
left a comment
2010YOUY01
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thank you!
This suggestion is totally optional, it would be great to move it to sqllogictest, due to 1. the test can be stronger as it exercises the behavior end-to-end 2. easier to maintain (I found rust tests regularly need updates during refactors, and they're harder to review)
To do that, sqllogictest provides Rust hooks to setup tables with orders, and we can use explain/explain analyzes to assert if the ordered path is triggered, and if spill happens.
github-actions
Bot
added
sqllogictest
pull Bot
pushed a commit
to TCeason/arrow-datafusion
that referenced
this pull request
Aug 2, 2026
## Which issue does this PR close? - Part of apache#13431 ## Rationale for this change Contuining the work after apache#23947. Now `SortMergeJoinExec` supports spilling under memory pressure, but existing tests do not consistently assert that spilling occurs. ## What changes are included in this PR? Adds spill fuzz coverage, constrained-memory stress tests for materializing joins, and process-isolated memory-limit validation. ## Are these changes tested? test only change and it can be tested via: ``` cargo test -p datafusion --test fuzz --features extended_tests spill cargo test -p datafusion --test core_integration --features extended_tests smj_ ``` ## Are there any user-facing changes? no test only change
kosiew
pushed a commit
to kosiew/datafusion
that referenced
this pull request
Aug 12, 2026
## Which issue does this PR close? - Not closes but part of apache#13431 ## Rationale for this change `GroupedHashAggregateStream` supports spilling for partially sorted group input, but existing aggregate spill tests only cover unordered (`GroupOrdering::None`) input. The `GroupOrdering::Partial` + `OutOfMemoryMode::Spill` path, including spilling sorted intermediate state and merging it back, does not have direct coverage. ## What changes are included in this PR? added test coverage for the case above ## Are these changes tested? test only change and it can be tested via: ``` cargo test --test sqllogictests -- ordered_aggregate_spill ``` ## Are there any user-facing changes? no test only change
kosiew
pushed a commit
to kosiew/datafusion
that referenced
this pull request
Aug 12, 2026
## Which issue does this PR close? - Part of apache#13431 ## Rationale for this change Contuining the work after apache#23947. Now `SortMergeJoinExec` supports spilling under memory pressure, but existing tests do not consistently assert that spilling occurs. ## What changes are included in this PR? Adds spill fuzz coverage, constrained-memory stress tests for materializing joins, and process-isolated memory-limit validation. ## Are these changes tested? test only change and it can be tested via: ``` cargo test -p datafusion --test fuzz --features extended_tests spill cargo test -p datafusion --test core_integration --features extended_tests smj_ ``` ## Are there any user-facing changes? no test only change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
GroupedHashAggregateStreamsupports spilling for partially sorted group input, but existing aggregate spill tests only cover unordered (GroupOrdering::None) input. TheGroupOrdering::Partial+OutOfMemoryMode::Spillpath, including spilling sorted intermediate state and merging it back, does not have direct coverage.What changes are included in this PR?
added test coverage for the case above
Are these changes tested?
test only change and it can be tested via:
Are there any user-facing changes?
no test only change