Skip to content

DRILL-5917: Ban org.json:json library in Drill#1031

Closed
vrozov wants to merge 1 commit into
apache:masterfrom
vrozov:DRILL-5917
Closed

DRILL-5917: Ban org.json:json library in Drill#1031
vrozov wants to merge 1 commit into
apache:masterfrom
vrozov:DRILL-5917

Conversation

@vrozov

@vrozov vrozov commented Nov 10, 2017

Copy link
Copy Markdown
Member

@arina-ielchiieva Please review

@paul-rogers paul-rogers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

arina-ielchiieva pushed a commit to arina-ielchiieva/drill that referenced this pull request Nov 13, 2017
@arina-ielchiieva

Copy link
Copy Markdown
Member

@vrozov when I have deployed Drill with your changes on test cluster, Drill start up failed with the following error:

2017-11-13 01:30:12,3367 ERROR JniCommon fs/client/fileclient/cc/jni_MapRClient.cc:616 Thread: 26996 Mismatch found for java and native libraries java build version 5.2.2.44680GA, native build version 5.2.2.44680.GA java patch vserion $Id: mapr-version: 5.2.2.44680GA 44680:b0ba7dcefd80b9aaf39f05f3, native patch version $Id: mapr-version: 5.2.2.44680.GA 44680:b0ba7dcefd80b9aaf39f05f
2017-11-13 01:30:12,3368 ERROR JniCommon fs/client/fileclient/cc/jni_MapRClient.cc:626 Thread: 26996 Client initialization failed.
Exception in thread "main" org.apache.drill.exec.exception.DrillbitStartupException: Failure during initial startup of Drillbit.
	at org.apache.drill.exec.server.Drillbit.start(Drillbit.java:353)
	at org.apache.drill.exec.server.Drillbit.start(Drillbit.java:323)
	at org.apache.drill.exec.server.Drillbit.main(Drillbit.java:319)
Caused by: org.apache.drill.common.exceptions.DrillRuntimeException: Error during udf area creation [/user/root/drill/udf/registry] on file system [maprfs:///]
	at org.apache.drill.common.exceptions.DrillRuntimeException.format(DrillRuntimeException.java:49)
	at org.apache.drill.exec.expr.fn.registry.RemoteFunctionRegistry.createArea(RemoteFunctionRegistry.java:277)
	at org.apache.drill.exec.expr.fn.registry.RemoteFunctionRegistry.prepareAreas(RemoteFunctionRegistry.java:234)
	at org.apache.drill.exec.expr.fn.registry.RemoteFunctionRegistry.init(RemoteFunctionRegistry.java:105)
	at org.apache.drill.exec.server.Drillbit.run(Drillbit.java:167)
	at org.apache.drill.exec.server.Drillbit.start(Drillbit.java:349)
	... 2 more
Caused by: java.io.IOException: Could not create FileClient
	at com.mapr.fs.MapRFileSystem.lookupClient(MapRFileSystem.java:626)
	at com.mapr.fs.MapRFileSystem.lookupClient(MapRFileSystem.java:679)
	at com.mapr.fs.MapRFileSystem.makeDir(MapRFileSystem.java:1239)
	at com.mapr.fs.MapRFileSystem.mkdirs(MapRFileSystem.java:1276)
	at org.apache.hadoop.fs.FileSystem.mkdirs(FileSystem.java:1917)
	at org.apache.drill.exec.expr.fn.registry.RemoteFunctionRegistry.createArea(RemoteFunctionRegistry.java:254)
	... 6 more

Without your changes start up was successful.

@vrozov

vrozov commented Nov 13, 2017

Copy link
Copy Markdown
Member Author

@arina-ielchiieva Please attach the full log to JIRA.

@arina-ielchiieva

Copy link
Copy Markdown
Member

@vrozov I have posted all content of drillbit.out. drillbit.log just had information that could not create remote function registry directory.

@vrozov

vrozov commented Nov 13, 2017

Copy link
Copy Markdown
Member Author

@arina-ielchiieva Please test with the latest commit. I changed mapr version back to 5.2.1, note that 2.7.0-mapr-1707 is compiled with 5.2.2

arina-ielchiieva pushed a commit to arina-ielchiieva/drill that referenced this pull request Nov 14, 2017
@vrozov

vrozov commented Nov 17, 2017

Copy link
Copy Markdown
Member Author

@arina-ielchiieva Please test

@arina-ielchiieva

arina-ielchiieva commented Nov 17, 2017

Copy link
Copy Markdown
Member

Test cluster is down for the weekend. You can test it locally, just run mvn clean install -Pmapr.

@vrozov

vrozov commented Nov 17, 2017

Copy link
Copy Markdown
Member Author

I already tested mapr and default profile locally. Once test pass on your cluster, let me know and I'll squash commits.

@arina-ielchiieva

Copy link
Copy Markdown
Member

I see some functional test failures but I don't think they are related, it might be that your branch is not based on the latest master, so +1, LGTM.
@vrozov thanks for making the changes!

@vrozov

vrozov commented Nov 22, 2017

Copy link
Copy Markdown
Member Author

rebased to upstream/master and squashed commits.

@asfgit asfgit closed this in 23e6565 Nov 22, 2017
@vrozov vrozov deleted the DRILL-5917 branch November 27, 2017 22:57
KulykRoman pushed a commit to KulykRoman/drill that referenced this pull request Nov 29, 2017
chunhui-shi pushed a commit to chunhui-shi/drill that referenced this pull request Dec 22, 2017
ilooner pushed a commit to ilooner/drill that referenced this pull request Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants