[FLINK-39729][table] Fix flaky CorrelateRestoreTest by using materialized data assertion#28224
Open
jnh5y wants to merge 1 commit into
Open
[FLINK-39729][table] Fix flaky CorrelateRestoreTest by using materialized data assertion#28224jnh5y wants to merge 1 commit into
jnh5y wants to merge 1 commit into
Conversation
…ized data assertion Generated-by: Claude Code (claude-opus-4-6)
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix flaky
CorrelateRestoreTest.testRestore[8](CORRELATE_WITH_LITERAL_AGG) by switching from changelog sequence assertion to materialized data assertion.Brief change log
CORRELATE_WITH_LITERAL_AGGtest program sink fromconsumedBeforeRestore()/changelog mode toconsumedValues()+testMaterializedData(), checking final materialized state[+I[2], +I[3]]instead of exact changelog ordering.Verifying this change
This change only modifies test infrastructure. The fix addresses non-deterministic record interleaving in the multi-source streaming plan (3 sources → InnerJoin + LeftOuterJoin + SemiJoin) that causes intermittent test failures.
The
testMaterializedData()pattern is already used byMultiJoinTestProgramsandDeltaJoinTestProgramsfor the same class of non-determinism.Generated-by: Claude Code (claude-opus-4-6)