Added support for running pyHttpd on Windows#665
Open
PaulLodge wants to merge 2 commits into
Open
Conversation
PaulLodge
changed the title
PaulLodge
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an update that enables running pyHttpd on windows.
the build-win.bat, first installs all the needed dependencies, this is done using vcpkg and the script used is very similar in approach to the GHA, it then builds, compiles and installs httpd in an arbitrary directory, at the beginning of the install phase the config.ini is created, it's only at this time cmake knows for sure where the install directory is and therefore httpd.
Prerequisites:
curl: this is needed in some of the tests, currently the curl included in windows isn't the same as it's Linux counterpart and as such needs to be pre-installed (from curl.se). once the install is complete the config_win.ini.in (curl_bin) will need updating with the full path, before running the above mentioned build-win.bat script.
Caveat:
h2load: currently this requires cygwin or similar to be installed, and all tests that run it are skipped (from the command line when pytest is run).
Tested on Linux to ensure that the changes didn't break anything 🤞🏻