feat: add row delta update#721
Open
manuzhang wants to merge 3 commits into
Open
Conversation
Implements the RowDelta update builder, table and transaction factory methods, and focused tests for row-level add/delete flows. Co-authored-by: Codex <codex@openai.com>
Keeps mixed row removals out of delete snapshots and validates staged deletion vectors against concurrent DV additions. Co-authored-by: Codex <codex@openai.com>
WZhuo
reviewed
Jun 16, 2026
Classify row deltas that add only delete files as delete operations, even when they also remove data files. Let ValidateDeletedFiles skip missing-file checks for empty tables, and use the default added-DV validation path. Co-authored-by: Codex <codex@openai.com>
manuzhang
force-pushed
the
codex/row-delta
branch
from
0dea7d5 to
27a496b
Compare
WZhuo
reviewed
Jun 18, 2026
|
|
||
| Status RowDelta::ValidateNoConflictingFileAndPositionDeletes() const { | ||
| std::vector<std::string> conflicting_files; | ||
| for (const auto& file : removed_data_files_) { |
Contributor
There was a problem hiding this comment.
Suggestion: conflicting_files could use std::vector<std::string_view> instead of std::vector<std::string> to avoid unnecessary string copies.
This is safe because:
file->file_pathis astd::stringmember ofDataFileremoved_data_files_holdsshared_ptr<DataFile>, so the backing strings live through the functionconflicting_filesis a local only consumed byFormatRangebefore returning — thestring_views never escape the scope
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the RowDelta update builder, table and transaction factory methods, and focused tests for row-level add/delete flows.