feat: add uniqueValue optimization for notEq/notIn in InclusiveMetricsEvaluator#754
Merged
Conversation
…sEvaluator
When a column has a single unique value (no nulls, no NaNs, and lower
bound == upper bound), notEq(X) and notIn({...X...}) can prune files
where that unique value matches the predicate, returning ROWS_CANNOT_MATCH.
Previously these always returned ROWS_MIGHT_MATCH, never pruning.
This mirrors the upstream Java InclusiveMetricsEvaluator.uniqueValue()
logic. The StrictMetricsEvaluator is unchanged: its existing bounds-based
notEq/notIn logic already covers the single-value case, matching upstream
Java which has no uniqueValue helper there.
Ports the corresponding testNotEqWithSingleValue/testNotInWithSingleValue
cases from the Java test suite.
zhjwpku
approved these changes
Jun 18, 2026
zhjwpku
left a comment
zhjwpku
left a comment
Collaborator
There was a problem hiding this comment.
I checked the java's impl, LGTM
Co-authored-by: Junwang Zhao <zhjwpku@gmail.com>
wgtmac
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a column has a single unique value (no nulls, no NaNs, and lower bound == upper bound), notEq(X) and notIn({...X...}) can prune files where that unique value matches the predicate, returning ROWS_CANNOT_MATCH. Previously these always returned ROWS_MIGHT_MATCH, never pruning.
This mirrors the upstream Java InclusiveMetricsEvaluator.uniqueValue() logic. The StrictMetricsEvaluator is unchanged: its existing bounds-based notEq/notIn logic already covers the single-value case, matching upstream Java which has no uniqueValue helper there.
Ports the corresponding testNotEqWithSingleValue/testNotInWithSingleValue cases from the Java test suite.