REST: Add missing endpoint check for creating views#3442
Open
ebyhr wants to merge 1 commit into
Open
Conversation
ebyhr
force-pushed
the
ebi/create-view-endpoint
branch
from
a812a14 to
af2746f
Compare
abnobdoss
approved these changes
May 31, 2026
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that's incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
Member
Author
|
@Fokko @kevinjqliu @geruh could you review this PR when you have time? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The endpoint check for a new view creation is missing.
Iceberg Java also validates it https://github.com/apache/iceberg/blob/be27af46df4316b41787a62382c5aa330a173c1e/core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java#L1670-L1672
create_viewto REST Catalog #2154Are these changes tested?
No
Are there any user-facing changes?
No