Skip to content

Improve PowerShell execution and failure backoff for Windows disk metrics collection#17747

Open
Caideyipi wants to merge 1 commit into
masterfrom
cp-sia
Open

Improve PowerShell execution and failure backoff for Windows disk metrics collection#17747
Caideyipi wants to merge 1 commit into
masterfrom
cp-sia

Conversation

@Caideyipi
Copy link
Copy Markdown
Collaborator

Description

  • Improve the stability of Windows disk metrics collection when invoking PowerShell.
  • Prefer the powershell.exe under SystemRoot / windir to reduce PATH dependency.
  • Add a 5-minute retry backoff on failures and throttle repeated failure logs.
  • Introduce a PowerShell executor abstraction and add unit tests for both the success path and failure backoff case.

This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants