failsafe:integration-test from contextual menu#3470
Conversation
mbien
added
Java
matthiasblaesing
left a comment
matthiasblaesing
left a comment
There was a problem hiding this comment.
Thank you - looks sane to me. Please fix the minimal nitpick I found.
| if (ActionProviderImpl.COMMAND_INTEGRATION_TEST_SINGLE.equals(action) || | ||
| ActionProviderImpl.COMMAND_DEBUG_INTEGRATION_TEST_SINGLE.equals(action) || | ||
| "profile-tests".equals(action)) | ||
| { //NOI18N - profile-tests is not really nice but well. |
There was a problem hiding this comment.
Please move the NOI18N onto the line where the string is located (one line up). Else it is not connected to that string. (Yes I know that there other locations in that file, that are missing NOI18N markers or have them on the next line, but ...)
There was a problem hiding this comment.
@abourree I saw the updated commit - would you mind squashing the to commits into one?
abourree
force-pushed
the
feature/failsafe_integration-test
branch
from
36fa5cc to
cb792fc
Compare
|
Sorry, I try to squash commits, but look not working |
abourree
force-pushed
the
feature/failsafe_integration-test
branch
from
2624a25 to
15a98c1
Compare
|
@abourree seems you managed to do it, thank you :-) - I activated the test runs and if they run clean, I'll merge. I assume you read the license statement at the top of the file and understood, that you donate your changeset to the ASF. |
3 participants
When editing JUnit class of integration test, I expect "Test File", "Debug Test File", "Run Focused Test Method" or "Debug Focused Test Method" to run "integration-test.single" or "debug.integration-test.single" actions instead of "test.single" or "debug.test.single".
The goal of this feature is to run integration test during integration-test phase and so after pre-integration-test.