[lance] Reject unsupported element types nested in ARRAY - #9102
Merged
Conversation
LanceRowTypeVisitor.visit(ArrayType) returned without checking the element type, so MULTISET/MAP/LOCAL_ZONED_TIMESTAMP passed validateDataFields when nested in an ARRAY even though they are rejected at the top level and inside ROW.
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
LanceRowTypeVisitor.visit(ArrayType)returned without checking the element type, soMULTISET/MAP/LOCAL_ZONED_TIMESTAMPpassedvalidateDataFieldswhen nested in anARRAY, even though the visitor rejects them at the top level and recurses throughROW.ARRAY<MULTISET<...>>then failed at write time inArrowFieldTypeConversion.visit(MultisetType)instead of atCREATE TABLE.Recurse into the element type, same as
VortexFileFormat(#8690) andMosaicFileFormat.Tests
LanceFileFormatTest— added a rejecting case forARRAY<MULTISET<STRING>>and keptARRAY<ARRAY<INT>>passing. 7/7 pass; both fail without the fix.