You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While IN (existing, missing) skips non-existent snapshots or schemas, the case where snapshot_id = missing is still hardcoded in new tests to throw an exception; this creates inconsistent predicate semantics for the same system table, whereas returning an empty set for non-existent IDs would be more logical for SQL queries. Additionally, the exists → read flow remains susceptible to a TOCTOU (Time-of-Check to Time-of-Use) race condition involving snapshot expiration.
While IN (existing, missing) skips non-existent snapshots or schemas, the case where snapshot_id = missing is still hardcoded in new tests to throw an exception; this creates inconsistent predicate semantics for the same system table, whereas returning an empty set for non-existent IDs would be more logical for SQL queries. Additionally, the exists → read flow remains susceptible to a TOCTOU (Time-of-Check to Time-of-Use) race condition involving snapshot expiration.
Hi @JingsongLi thanks for review, have updated the equality semantics to match IN filter, both do not fail on invalid snapshot ids, also fixed the TOCTOU concern. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
snapshot_id in (...)statement fails when the in clause is supplied with a non existent snapshot id.Tests