This repository was archived by the owner on May 10, 2024. It is now read-only.
PARQUET-662: Compile ParquetException implementation and explicitly export#139
Closed
wesm wants to merge 1 commit into
Closed
PARQUET-662: Compile ParquetException implementation and explicitly export#139wesm wants to merge 1 commit into
wesm wants to merge 1 commit into
Conversation
Member
Author
|
I verified locally that this resolves the downstream failure on OS X. May be possible to write a test case here that uses the shared lib. @majetideepak @xhochy let me know what you think |
Member
Author
|
I added a simple option to |
Contributor
|
+1 |
…KAGE option to ADD_PARQUET_TEST, test throwing ParquetException via shared lib. Build shared library in gcc build.
Member
Author
|
Thanks. I cleaned up the cmake function a bit and will merge on green build. |
|
+1 LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was causing downstream failure in ARROW-237. Now thirdparty libraries can safely throw
ParquetExceptionand be properly recognized on both ends.