Skip to content

PARQUET-2441: Upgrading Spotless to 0.43.0 & Scala to 2.12.19#1287

Closed
vinooganesh wants to merge 2 commits into
apache:masterfrom
vinooganesh:vinooganesh/UpgradeSpotlessTo2.43.0
Closed

PARQUET-2441: Upgrading Spotless to 0.43.0 & Scala to 2.12.19#1287
vinooganesh wants to merge 2 commits into
apache:masterfrom
vinooganesh:vinooganesh/UpgradeSpotlessTo2.43.0

Conversation

@vinooganesh

@vinooganesh vinooganesh commented Mar 1, 2024

Copy link
Copy Markdown
Contributor

Currently building off of master is broken because of:

[ERROR] Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.30.0:check (default) on project parquet-format-structures: Execution default of goal com.diffplug.spotless:spotless-maven-plugin:2.30.0:check failed: java.lang.reflect.InvocationTargetException: 'com.sun.tools.javac.tree.JCTree com.sun.tools.javac.tree.JCTree$JCImport.getQualifiedIdentifier()' -> [Help 1]

Arrow hit the same issue: apache/datafusion-comet#85 because of this: diffplug/spotless#1774. Bumping spotless to fix building on master.

It is also broken because of this scala/bug#12783. Scala cut and released a fix that was merged into 2.12.19: scala/scala@9ee7c1e.


Jira

  • My PR addresses the following Parquet Jira issues and references
    them in the PR title. For example, "PARQUET-1234: My Parquet PR"

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason: Library bump

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines
    from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Style

  • My contribution adheres to the code style guidelines and Spotless passes.
    • To apply the necessary changes, run mvn spotless:apply -Pvector-plugins

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@vinooganesh

Copy link
Copy Markdown
Contributor Author

@shangxinli @Fokko can I get a quick approval for tests?

@vinooganesh vinooganesh changed the title PARQUET-2441: Upgrading Spotless to 0.43.0 PARQUET-2441: Upgrading Spotless to 0.43.0 & Scala to 2.12.19 Mar 1, 2024
@wgtmac

wgtmac commented Mar 3, 2024

Copy link
Copy Markdown
Member

@vinooganesh Could you please fix the CI?

@vinooganesh

Copy link
Copy Markdown
Contributor Author

Absolutely, I'll get the tests fixed this week and reping

@vinooganesh

Copy link
Copy Markdown
Contributor Author

Root caused this as a local issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants