Support Reader Listener#153
Merged
Merged
Conversation
hrsakai
reviewed
May 18, 2021
| } else { | ||
| this->listener = this->readerConfig->GetListenerCallback(); | ||
| } | ||
| delete this->readerConfig; |
Contributor
There was a problem hiding this comment.
if result is not ok, won't this line be executed?
Contributor
Author
There was a problem hiding this comment.
Exactly. If the result is not ok, this is not be executed.
I fixed that this is be done if the result is not ok.
Contributor
There was a problem hiding this comment.
I think it is better to write as follows.
https://github.com/apache/pulsar-client-node/blob/v1.3.0/src/Consumer.cc#L180-L187
Contributor
Author
There was a problem hiding this comment.
I implemented createReaderCallback like subscribeCallback.
hrsakai
reviewed
May 18, 2021
| if (this->listener) { | ||
| this->CleanupListener(); | ||
| } | ||
| pulsar_reader_free(this->wrapper->cReader); |
Contributor
There was a problem hiding this comment.
Can we delete this line because pulsar_reader_free is executed on CReaderWrapper::~CReaderWrapper?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add listener function to the Reader, using the C++ client listener support.