Skip to content

Fix input port mapping not passed into data processor in some cases#1812

Merged
Xiao-zhen-Liu merged 1 commit into
masterfrom
zuozhi-fix-input-port
Jan 27, 2023
Merged

Fix input port mapping not passed into data processor in some cases#1812
Xiao-zhen-Liu merged 1 commit into
masterfrom
zuozhi-fix-input-port

Conversation

@zuozhiw

@zuozhiw zuozhiw commented Jan 27, 2023

Copy link
Copy Markdown
Contributor

This PR fixes an issue introduced in #1793 . In some scenarios, the inputPortMapping is not correctly passed into the data processor due to an initilaization order issue of a lazily evaluated variable. This causes the join operator to not produce results because it wrongly thinks all the input data are from the build side.

This PR does a temporary hot-fix of this issue, this issue will be completely solved once #1807 is merged into master.

@zuozhiw zuozhiw requested a review from Xiao-zhen-Liu January 27, 2023 21:07

@Xiao-zhen-Liu Xiao-zhen-Liu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xiao-zhen-Liu Xiao-zhen-Liu merged commit 26aa777 into master Jan 27, 2023
@Xiao-zhen-Liu Xiao-zhen-Liu deleted the zuozhi-fix-input-port branch January 27, 2023 22:15
yangzhang75 pushed a commit to yangzhang75/texera that referenced this pull request Jun 22, 2026
…pache#1812)

This PR fixes an issue introduced in apache#1793 . In some scenarios, the
`inputPortMapping` is not correctly passed into the data processor due
to an initilaization order issue of a lazily evaluated variable. This
causes the join operator to not produce results because it wrongly
thinks all the input data are from the build side.

This PR does a temporary hot-fix of this issue, this issue will be
completely solved once apache#1807 is merged into master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants