ci(release): gate RC creation on strict-mode build of the tagged commit#4857
Merged
Conversation
Add a build job at the top of create-release-candidate.yml that calls the reusable build.yml with checkout_ref=<input.tag> and mode=release. create-rc now depends on it via needs: build. Closes the gap where an RC could be cut from a tag that doesn't compile or has license-binary drift only the nightly cron would catch. Closes apache#4856 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
bobbai00
added
the
release/v1.1.0-incubating
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4857 +/- ##
============================================
+ Coverage 43.34% 43.40% +0.05%
- Complexity 2035 2108 +73
============================================
Files 957 957
Lines 34077 34946 +869
Branches 3753 3893 +140
============================================
+ Hits 14772 15167 +395
- Misses 18512 18975 +463
- Partials 793 804 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aglinxinyuan
approved these changes
May 3, 2026
Yicong-Huang
pushed a commit
that referenced
this pull request
May 3, 2026
…it (#4857) ### What changes were proposed in this PR? Add a \`build\` job at the top of \`create-release-candidate.yml\` that calls the reusable \`build.yml\` with: - \`checkout_ref: \${{ github.event.inputs.tag }}\` — build the tagged commit (\`build.yml\` already accepts this input). - \`mode: release\` — strict license-binary check, no \`--ignore-transitive-version\` (the third mode added in #4734 alongside \`PR\` and \`nightly\`). \`create-rc\` now depends on \`build\` via \`needs: build\`. If the tag doesn't compile or has license-binary drift, no RC tarball is produced and nothing is signed/uploaded to ASF SVN. ### Any related issues, documentation, discussions? Closes #4856. ### How was this PR tested? ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (claude-opus-4-7) (backported from commit 31adc70) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Backport to |
yangzhang75
pushed a commit
to yangzhang75/texera
that referenced
this pull request
Jun 22, 2026
…it (apache#4857) ### What changes were proposed in this PR? Add a \`build\` job at the top of \`create-release-candidate.yml\` that calls the reusable \`build.yml\` with: - \`checkout_ref: \${{ github.event.inputs.tag }}\` — build the tagged commit (\`build.yml\` already accepts this input). - \`mode: release\` — strict license-binary check, no \`--ignore-transitive-version\` (the third mode added in apache#4734 alongside \`PR\` and \`nightly\`). \`create-rc\` now depends on \`build\` via \`needs: build\`. If the tag doesn't compile or has license-binary drift, no RC tarball is produced and nothing is signed/uploaded to ASF SVN. ### Any related issues, documentation, discussions? Closes apache#4856. ### How was this PR tested? ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (claude-opus-4-7) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Add a `build` job at the top of `create-release-candidate.yml` that calls the reusable `build.yml` with:
`create-rc` now depends on `build` via `needs: build`. If the tag doesn't compile or has license-binary drift, no RC tarball is produced and nothing is signed/uploaded to ASF SVN.
Any related issues, documentation, discussions?
Closes #4856.
How was this PR tested?
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (claude-opus-4-7)