chore(pyright-language-service): remove unused hocon-parser and hoconjs dependencies#5581
Merged
Yicong-Huang merged 1 commit intoJun 12, 2026
Conversation
github-actions
Bot
added
the
dependencies
Contributor
|
Could you assign a reviewer for this PR? @chenlica |
Contributor
|
I am actually not sure if we still need those files, because we don't have test cases to guard it. Not sure if language service can still work with this change. I don't want to change it like this way unless we have verified it somehow. |
Contributor
|
@Yicong-Huang Do you want to close this PR or want @yangzhang75 to provide more information? |
Contributor
|
Given that we don't have enough data point of these files being used, I will approve this PR and let's merge it. We can revert this if it causes issues in later deployment stage. |
Yicong-Huang
approved these changes
Jun 12, 2026
yangzhang75
added a commit
to yangzhang75/texera
that referenced
this pull request
Jun 22, 2026
…js dependencies (apache#5581) <!-- Thanks for sending a pull request (PR)! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: [Contributing to Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) 2. Ensure you have added or run the appropriate tests for your PR 3. If the PR is work in progress, mark it a draft on GitHub. 4. Please write your PR title to summarize what this PR proposes, we are following Conventional Commits style for PR titles as well. 5. Be sure to keep the PR description updated to reflect all changes. --> ### What changes were proposed in this PR? <!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes. Here are some tips for you: 1. If you propose a new API, clarify the use case for a new API. 2. If you fix a bug, you can clarify why it is a bug. 3. If it is a refactoring, clarify what has been changed. 3. It would be helpful to include a before-and-after comparison using screenshots or GIFs. 4. Please consider writing useful notes for better and faster reviews. --> Removes the dead hocon-parser integration from pyright-language-service. The hoconParser call was removed in apache#3150 (when the language server became a standalone microservice) and the leftover import in apache#3415, but the two dependencies and the type stub were never cleaned up. - Delete src/types/hocon-parser.d.ts (type stub for an unused module) - Remove hocon-parser and hoconjs from package.json - Regenerate yarn.lock via yarn install ### Any related issues, documentation, discussions? <!-- Please use this section to link other resources if not mentioned already. 1. If this PR fixes an issue, please include `Fixes apache#1234`, `Resolves apache#1234` or `Closes apache#1234`. If it is only related, simply mention the issue number. 2. If there is design documentation, please add the link. 3. If there is a discussion in the mailing list, please add the link. --> Closes apache#5442 ### How was this PR tested? <!-- If tests were added, say they were added here. Or simply mention that if the PR is tested with existing test cases. Make sure to include/update test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. If tests were not added, please describe why they were not added and/or why it was difficult to add. --> - `grep -rn "hocon" pyright-language-service/src` returns nothing - The TypeScript build passes (`tsc --noEmit -p tsconfig.json`, exit 0) - No code in the service imports hocon-parser/hoconjs, so this is a pure dead-code removal ### Was this PR authored or co-authored using generative AI tooling? <!-- If generative AI tooling has been used in the process of authoring this PR, please include the phrase: 'Generated-by: ' followed by the name of the tool and its version. If no, write 'No'. Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details. --> Generated-by: Claude Code (Claude Opus 4.8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Removes the dead hocon-parser integration from pyright-language-service. The hoconParser call was removed in #3150 (when the language server became a standalone microservice) and the leftover import in #3415, but the two dependencies and the type stub were never cleaned up.
Any related issues, documentation, discussions?
Closes #5442
How was this PR tested?
grep -rn "hocon" pyright-language-service/srcreturns nothingtsc --noEmit -p tsconfig.json, exit 0)Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 4.8)