Try to fix master pipeline - #3756
Merged
Merged
Conversation
antograssiot
force-pushed
the
fix-pipeline
branch
from
October 13, 2020 12:38
393d8bc to
2749a2f
Compare
antograssiot
force-pushed
the
fix-pipeline
branch
from
October 13, 2020 13:11
2749a2f to
e2dc817
Compare
Member
|
But then we don't test the use of this component at all? Maybe should we add a new job just for that? |
Member
|
see also #3715 We do test the component 👍 to not install this on legacy versions |
soyuka
approved these changes
Oct 14, 2020
Contributor
Author
|
Yes we do test it in other pipelines but on on the legacy suite that runs only on SF ^3.4|^4.0 |
Member
|
thansk @antograssiot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We might want to skip the installation of symfony/uid for legacy tests completely. The rationale behind this is that we can't install this package when the symfony requirement is limited to
^3.4 | ^4.0only.