feat(doctrine): boolean filter like laravel filters - #6749
Closed
vinceAmstoutz wants to merge 1 commit into
Closed
Conversation
soyuka
requested changes
Oct 25, 2024
vinceAmstoutz
force-pushed
the
feat-doctrine-boolean-filter-like-laravel-filters
branch
6 times, most recently
from
October 26, 2024 14:14
cc689c3 to
c5de0d4
Compare
Member
Author
|
@soyuka looks like this in Swagger UI: |
vinceAmstoutz
force-pushed
the
feat-doctrine-boolean-filter-like-laravel-filters
branch
7 times, most recently
from
October 26, 2024 18:47
2e2f570 to
1892e6a
Compare
vinceAmstoutz
marked this pull request as ready for review
October 26, 2024 18:57
soyuka
reviewed
Oct 28, 2024
soyuka
left a comment
Member
There was a problem hiding this comment.
Nice start! A few comments left to be done!
vinceAmstoutz
force-pushed
the
feat-doctrine-boolean-filter-like-laravel-filters
branch
5 times, most recently
from
October 31, 2024 15:35
04a24ac to
b1026cb
Compare
soyuka
approved these changes
Nov 4, 2024
vinceAmstoutz
force-pushed
the
feat-doctrine-boolean-filter-like-laravel-filters
branch
3 times, most recently
from
November 4, 2024 11:26
6887caf to
a5fe140
Compare
soyuka
requested changes
Nov 4, 2024
vinceAmstoutz
force-pushed
the
feat-doctrine-boolean-filter-like-laravel-filters
branch
2 times, most recently
from
November 4, 2024 16:02
1130a1a to
13c15dd
Compare
vinceAmstoutz
force-pushed
the
feat-doctrine-boolean-filter-like-laravel-filters
branch
2 times, most recently
from
November 5, 2024 09:00
c5c4b19 to
cbe1cff
Compare
vinceAmstoutz
force-pushed
the
feat-doctrine-boolean-filter-like-laravel-filters
branch
from
November 5, 2024 09:25
cbe1cff to
fd22d9c
Compare
vinceAmstoutz
deleted the
feat-doctrine-boolean-filter-like-laravel-filters
branch
November 5, 2024 09:55
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



mainGoal:
Using filters as we use Laravel filters. Example with Symfony:
#[ApiResource] #[GetCollection( parameters: [ 'active' => new QueryParameter( filter: new BooleanFilter(), ), // support also for filter aliasing 'enabled' => new QueryParameter( filter: new BooleanFilter(), property: 'active', ), ], )] #[ORM\Entity] class FilteredBooleanParameter { // ... }TODO: