Skip to content

feat(swagger-ui): persist authorization - #6877

Merged
soyuka merged 11 commits into
api-platform:4.1from
ViPErCZ:feature/persistAuthorization
Jan 17, 2025
Merged

feat(swagger-ui): persist authorization#6877
soyuka merged 11 commits into
api-platform:4.1from
ViPErCZ:feature/persistAuthorization

Conversation

@ViPErCZ

@ViPErCZ ViPErCZ commented Dec 18, 2024

Copy link
Copy Markdown
Contributor

[FTR] add Swagger UI config directive: persistAuthorization

@ViPErCZ ViPErCZ changed the title Feature/persist authorization feat(swagger-ui): persist authorization Dec 18, 2024
@jpcaparas

Copy link
Copy Markdown

I second this change. It's much better to have the ability to persist authorization rather than having to type in the PKCE client ID each time.

@soyuka

soyuka commented Jan 9, 2025

Copy link
Copy Markdown
Member

can you target the 4.1 or main branch?

@ViPErCZ

ViPErCZ commented Jan 9, 2025

Copy link
Copy Markdown
Contributor Author

can you target the 4.1 or main branch?

only 4.1 version (branch) is OK for me ❤️

@ViPErCZ

ViPErCZ commented Jan 15, 2025

Copy link
Copy Markdown
Contributor Author

@soyuka Do I need to do anything else?

@soyuka
soyuka changed the base branch from 4.0 to 4.1 January 16, 2025 07:35
@soyuka

soyuka commented Jan 16, 2025

Copy link
Copy Markdown
Member

I changed the target branch to 4.1 but this needs a rebase, also it looks like test failures are related, feel free to ping me on slack if you've trouble running tests.

@ViPErCZ

ViPErCZ commented Jan 16, 2025

Copy link
Copy Markdown
Contributor Author

@soyuka I fixed the merge conflicts and tests (my unit tests are also running locally), but some Laravel tests are still crashing. Can you please take a look? Thank you.

@soyuka soyuka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add these myself feel free to comment if you've a question. I'll probably release that tomorrow in a beta version.

Comment thread src/OpenApi/Options.php Outdated
Comment thread src/OpenApi/Options.php Outdated
Comment thread src/Symfony/Bundle/SwaggerUi/SwaggerUiAction.php Outdated
Comment thread src/Symfony/Bundle/SwaggerUi/SwaggerUiProcessor.php Outdated
Comment thread src/Symfony/Bundle/DependencyInjection/Configuration.php Outdated
Comment thread src/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php Outdated
Comment thread tests/Symfony/Bundle/DependencyInjection/ConfigurationTest.php Outdated
Comment thread src/Symfony/Bundle/Resources/config/openapi.xml Outdated
Comment thread src/Laravel/ApiPlatformProvider.php Outdated
@ViPErCZ

ViPErCZ commented Jan 17, 2025

Copy link
Copy Markdown
Contributor Author

@soyuka thanks... perfect

@soyuka
soyuka merged commit c97db6b into api-platform:4.1 Jan 17, 2025
GromNaN added a commit to GromNaN/api-platform-core that referenced this pull request Jan 30, 2025
Method OpenApi::hasPersistAuthorization() used by SwaggerUiAction

api-platform#6877
GromNaN added a commit to GromNaN/api-platform-core that referenced this pull request Jan 30, 2025
Method OpenApi::hasPersistAuthorization() used by SwaggerUiAction

api-platform#6877
jonerickson pushed a commit to jonerickson/core that referenced this pull request Feb 21, 2025
Co-authored-by: Antoine Bluchet <soyuka@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants