DUX-11214: Document unverified cache-write pricing gap for GPT-5.6 Bedrock entries - #23
Merged
Merged
Conversation
The hand-added openai.gpt-5.6-luna/-terra/-sol registry entries (7791056) omit cache_write_input_per_million. This matches every other OpenAI-family model in models.json, but that omission was never independently confirmed against OpenAI/Bedrock pricing docs for GPT-5.6 specifically. Document the gap next to the spec that already pins these three entries' pricing, so it's revisited once models.dev or AWS publish real data. Co-authored-by: Sam Boland <sam.boland@appfolio.com>
staging-supernova-dx-appf-io
Bot
requested a review
from a team
as a code owner
August 5, 2026 23:31
|
Jira Issue: https://appfolio.atlassian.net/browse/DUX-11214 |
Author
|
🤖 Supernova Code Review — View trace |
Author
There was a problem hiding this comment.
Reviewed this PR — it only adds an explanatory comment to a spec file (spec/ruby_llm/models_gpt_5_6_bedrock_spec.rb) documenting a known gap in pricing data for three hand-added model entries. No logic, behavior, or test assertions changed. Nothing actionable found; no inline comments.
samuelboland
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds documentation clarifying the absence of
cache_write_input_per_millionpricing rates for the three hand-added GPT-5.6 Bedrock model entries (openai.gpt-5.6-luna, openai.gpt-5.6-terra, openai.gpt-5.6-sol).Details
The comment documents that:
cache_write_input_per_millionrateMotivation
Provides context for future maintainers investigating the pricing model for these Bedrock entries and helps prevent accidental introduction of cache-write rates without proper verification against official pricing documentation.
Agent session: https://staging.supernova.dx.appf.io/coders/d4d3a719-2649-46c7-ad4f-ab22e5bd051e