Skip to content

Pin docker-cli and compose to exact apk versions #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ChiragAgg5k wants to merge 1 commit into from
+10 −4
Closed

Pin docker-cli and compose to exact apk versions #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# CHANGELOG

## Version 1.4.5

### Change

* Pin `docker-cli` and `docker-cli-compose` apk packages to the exact versions already shipped in `1.4.4` (`29.5.2-r0` and `2.40.3-r6`) so Alpine package floats cannot silently bump the installer Docker client. Structure tests now assert those exact versions.

## Version 1.3.2

### Security
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,8 +221,8 @@ RUN apk update && \
c-ares \
certbot \
freetype \
docker-cli \
docker-cli-compose \
docker-cli=29.5.2-r0 \
docker-cli-compose=2.40.3-r6 \
git \
icu-libs \
imagemagick \
Expand Down
4 changes: 2 additions & 2 deletions tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ commandTests:
- name: 'Docker command'
command: "docker"
args: ["--version"]
expectedOutput: ["Docker version 29.*"]
expectedOutput: ["Docker version 29.5.2.*"]

@greptile-apps greptile-apps Bot Jul 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Exact version regex is loose

The periods in 29.5.2 are regex wildcards and the expression lacks a version boundary, so output such as Docker version 29x5x20 can satisfy a test intended to enforce the exact Docker CLI version.

Suggested change
expectedOutput: ["Docker version 29.5.2.*"]
expectedOutput: ["Docker version 29[.]5[.]2($|,)"]
Prompt To Fix With AI 
This is a comment left during a code review.
Path: tests.yaml
Line: 19

Comment:
**Exact version regex is loose**

The periods in `29.5.2` are regex wildcards and the expression lacks a version boundary, so output such as `Docker version 29x5x20` can satisfy a test intended to enforce the exact Docker CLI version.

```suggestion
    expectedOutput: ["Docker version 29[.]5[.]2($|,)"]
```

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fix in Claude Code Fix in Codex

- name: 'Docker Compose command'
command: "docker"
args: ["compose", "version"]
expectedOutput: ["Docker Compose version v.*"]
expectedOutput: ["Docker Compose version v2.40.3"]
- name: 'Git command'
command: "git"
args: ["--version"]
Expand Down
Loading