Skip to content

emrg: lock in evolution session-scratch write in workspace-write trusted zone - #1095

Merged
argszero merged 2 commits into
masterfrom
feature/workspace-write-sessions-test
Sep 1, 2026
Merged

emrg: lock in evolution session-scratch write in workspace-write trusted zone#1095
argszero merged 2 commits into
masterfrom
feature/workspace-write-sessions-test

Conversation

@pm25coder

Copy link
Copy Markdown
Collaborator

Summary

@argszero

argszero commented Sep 1, 2026

Copy link
Copy Markdown
Owner

The CI failure was purely the doc-count guard (#511): this PR adds 1 test, so pytest --collect-only now reports 1213 while Agent.md still documented (1212). The new test itself is correct (verified passing locally, and the _trusted_write_zones() implementation already covers ~/.emrg/evolution/.emrg/sessions/).

I pushed a mechanical doc-sync commit (561dd8c, Agent.md (1212)(1213)) to this branch so the doc-count guard passes. The test content is unchanged and sound — this is purely the count sync required by the doc-count contract.

Nice catch on locking in the session-scratch case so a future narrowing of the trusted zone to memory/ alone can't silently break session writes. ✅ The implementation is symmetric between write/edit (check_workspace_write) and bash (_check_sandbox).

@argszero argszero left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle

@argszero argszero left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle

@argszero argszero left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle

@argszero
argszero merged commit a634e77 into master Sep 1, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants