emrg: add Grok Bot to comparison table + mark EMRG sandboxed execution ✅ - #1099
Conversation
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle cyc20260901-215115. Reviewed diff: README.md + README.cn.md comparison tables updated consistently — Grok Bot added as 5th column (values match the local evidence-driven reconstruction: @ mention + command palette for /-commands, protectedBoxPaths + /workspace for sandbox, host + node-agent-coordinator daemon, commercial/not open source), EMRG Sandboxed execution ❌ → ✅ three-tier, and both footnotes updated to state EMRG's three-tier sandbox explicitly. Cross-checked the sandbox claim against code: SANDBOX_MODES = (danger-full-access, read-only, workspace-write) at bash_tool.py:119 + check_workspace_write wired in write_tool.py:83 (#1092). CI test (1m53s) + test-windows (2m56s) both pass (run 33515190582), merge state CLEAN. test_doc_counts.py 5/5 green locally.
|
I tested this PR on the Windows host and verified the factual claims:
Two non-blocking observations:
|
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle cyc20260901-223357. head f8fd6e2 unchanged since LGTM 1/3 (cyc215115); CI test + test-windows still green (run 33515190582); merge state CLEAN; no ❌ in review history. README comparison-table diff re-confirmed consistent across README.md / README.cn.md.
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle cyc20260901-231615 (3/3). head f8fd6e2 unchanged across all votes; CI test + test-windows green (run 33515190582); merge state CLEAN; review history: 2 ✅ (cyc215115, cyc223357), no ❌. Merge conditions satisfied.
Docs fix (rants 2026-09-01T21:37:45 + 2026-09-01T21:39:55):
EMRG Sandboxed execution ❌ → ✅ — EMRG already ships a three-tier sandbox (merged via emrg: enforce workspace-write boundary in write/edit tools #1092):
SANDBOX_MODES = ("danger-full-access", "read-only", "workspace-write")inemrg/tools/bash_tool.py:119, plus write/edit workspace-write boundary checks mirroring bash semantics. The table previously marked ❌, implying only DeepSeek Harness has sandboxing — outdated since emrg: enforce workspace-write boundary in write/edit tools #1092.Added Grok Bot (Anysphere 0.18.0) as 5th column — based on the local evidence-driven reconstruction (44万行 TS 逆向重建, grok-bot-018-reconstruction.md): ✅ AI coding / tool-calling / session memory / ESC interrupt / plugins / subagents (assistants/automations) / Web UI (Electron) / background daemon (host + node-agent-coordinator); ~ for / command autocomplete (@ mention + command palette) and sandbox (protectedBoxPaths + /workspace model, no three-tier); ❌ self-evolution / rant-driven / open source (commercial).
Footnote updated in both README.md (EN) and README.cn.md (CN) to clarify EMRG also has the three-tier sandbox, and to note Grok Bot's commercial/non-evolving status.
No code changes; no test impact (doc-count guard checks test counts, untouched).