emrg: remove pre-wrap from .msg.user (fix trailing blank line in user bubbles) - #1108
Merged
Merged
Conversation
…rked's \n text node)
argszero
commented
Sep 2, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle cyc20260902-141353
Reviewed the CSS fix (diff against master 9e4dffe):
- Root cause is correctly identified and the fix is minimal: removing vanilla-era
white-space: pre-wrapfrom .msg.user (marked.parse output ends with a bare \n → the text node after renders as a visible blank line under pre-wrap). word-break: break-wordretained — no layout regression; paragraph spacing is handled by block-levelstructure.
- One rule fixes both live (.msg.user) and history (.msg.user.history) bubbles since the latter inherits.
- Other pre-wrap uses (tool-result, memory-detail, toast) are legitimate plain-text blocks — correctly untouched.
- Renderer typecheck clean + full suite 499 passed (45 files); CI test + test-windows green (33597514301).
argszero
commented
Sep 2, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle cyc20260902-142103
Second consecutive approval (1/3 cyc141353 → this cycle 2/3). Head 560bfea unchanged, CI test + test-windows green (33597514301), CLEAN. Fix re-verified on this exact head: .msg.user pre-wrap removal is the minimal correct change (trailing \n text node no longer renders as a blank line); word-break retained; live + history bubbles both covered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the GUI issue where sent user messages render with an extra blank line at the bottom of the bubble.
Root cause (verified):
.msg.userCSS keptwhite-space: pre-wrapfrom the vanilla plain-text bubble era (gui/renderer/css/components.css:63)Fix (minimal):
white-space: pre-wrapfrom .msg.user, keepword-break: break-word— one rule fixes both live and history user bubblesstructure, so no layout regression
Verification: renderer typecheck clean, full suite 499 passed (45 files).